Repository navigation
docs: correct pages made stale by #79 and #81 and describe the real output (D-a) - #88
Merged
Merged
Conversation
…utput (D-a) Text only; no code or behaviour change. - Empty AO values (#81): mrv-specification.md and input-prioritization.md said an empty value empties its neighbours and drops out of the fuel totals. It is interpolated in time between the nearest points with a value, as input-format.md already says. - Fuel flow derived from the AO mass (#79): describe the current formula (mass decrease to the next point / time to the next point). - output-format.md rewritten around runner.results: success entries, low-altitude zero results and error records (order, keys, examples that run), fleet_meta_data keys from report.py, bada_version / bada_code absent on the AO fuel flow + efficiency + mass path, multi-engine entries. The per-segment field list moves to a "Golden dump" section. - flight_schema.json: description strings only (hydrogen content wt.%, calorific value J/kg, departure/arrival times as supplied, EDB engine UID, load factor basis, whole-aircraft fuel flow, propulsion efficiency, flight level, TAS in m/s). - usage.md: working ZarrPaths and DWDFactory snippets; examples/README.md and example-scripts.md: units and the efficiency definition; EAGWP units W m-2 yr in the MRV formulas; hydrogen content formula in wt.%. Checked by independent reviewers over 5 rounds against the code on dev; every code example in output-format.md and the changed usage.md snippets were run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text only; no code or behaviour change.
mrv-specification.mdandinput-prioritization.mdsaid an emptyvalue empties its neighbours and drops out of the fuel totals. It is interpolated in time
between the nearest points with a value, as
input-format.mdalready says.next point / time to the next point).
output-format.mdrewritten aroundrunner.results: success entries, low-altitude zeroresults and error records (order, keys, examples that run),
fleet_meta_datakeys fromreport.py,bada_version/bada_codeabsent on the AO fuel flow + efficiency + mass path,multi-engine entries (DataFrame input with a list
engine_uidis not supported: tracked asDF-ME). The per-segment field list moves to a "Golden dump" section.
flight_schema.json, description strings only: hydrogen content wt.%, calorific valueJ/kg, departure/arrival times as supplied, EDB engine UID, load factor basis, whole-aircraft
fuel flow, propulsion efficiency, flight level, TAS in m/s (AO sends knots).
usage.md: workingZarrPathsandDWDFactorysnippets.examples/README.mdandexample-scripts.md: units and the efficiency definition.[W m-2]to[W m-2 yr]; hydrogen content formula now gives wt.% (x 100).Checks. Reviewed by independent checkers over 5 rounds against the code; every code example
in
output-format.mdand the changedusage.mdsnippets were run. Schema still valid; the 11golden inputs still validate against it. Non-weather suite: 407 passed.
Still to do (D-b):
input-format.mdfield definitions from the AO schema.Review. Ramon; Philippe for the two formula changes.