Repository navigation
fix(cache): fetch WASM in IIFE inline-bridge format - #15
Merged
Merged
Conversation
euv PR #250 replaced the external pkg/<name>.js module script with an inline IIFE that hardcodes the wasm URL as `var __euv_wasm_url = "pkg/<name>_bg.wasm"`. The cache fetcher previously only looked at <script src>, <link href>, <img src>, and ES module imports to discover resources. In the IIFE format there are no external script/link tags, so the wasm binary was never downloaded into the cache directory. The webview then 404'd on pkg/<name>_bg.wasm and rendered a blank white screen. Add extract_iife_wasm_url() which scans the HTML for the __euv_wasm_url marker and appends the quoted .wasm path to the resource list. Call it from both fetch_full_snapshot() (for verification) and fetch_linked_resources() (for the actual download). Fixes the white-screen regression introduced by euv-dev/euv#250.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
euv PR #250 replaced the external
pkg/<name>.jsmodule script with an inline IIFE that hardcodes the wasm URL asvar __euv_wasm_url = \"pkg/<name>_bg.wasm\".The cache fetcher previously only looked at
<script src>,<link href>,<img src>, and ES module imports to discover resources. In the IIFE format there are no external script/link tags, so the wasm binary was never downloaded into the cache directory. The webview then 404'd onpkg/<name>_bg.wasmand rendered a blank white screen.Fix
Add
extract_iife_wasm_url()which scans the HTML for the__euv_wasm_urlmarker and appends the quoted.wasmpath to the resource list. Call it from bothfetch_full_snapshot()(for verification) andfetch_linked_resources()(for the actual download).Fixes the white-screen regression introduced by euv-dev/euv#250.