Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ModelDriftMethodwrites atargetcolumn directly into each embedding DataFrame and then removes it from the classifier features. This mutates the caller's data and silently discards an existing embedding dimension namedtarget. If the same DataFrame is supplied for both samples, the second assignment overwrites both sets of labels, so fitting fails with a single-class error.Change
Construct the domain-classification target as a separate array in the same reference/current order as the concatenated embeddings. Preserve all input dimensions and leave the original DataFrames unchanged. PCA, train/test splitting, classifier configuration, and drift threshold logic stay the same.
Validation
Seven new tests cover input preservation with and without bootstrap/PCA, invariance under renaming an embedding dimension, and comparing a DataFrame with itself. On a fixture whose only separating dimension is named
target, the old implementation reports ROC AUC 0.4125 and no drift; renaming that dimension yields AUC 1.0. The fix makes the result independent of that column name. This is a correctness example, not a general accuracy or performance claim.git diff --check, pass.