Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Embedding distance and MMD bootstrap repeatedly call
np.random.seed(i)and draw from the process-global generator. The model-based drift bootstrap does the same throughcalc_roc_auc_random. Running a drift check therefore changes the random sequence used by later training, sampling, or evaluation code in the same process.Change
Use a local
np.random.RandomState(i)for each bootstrap repetition and for the random-AUC helper. Keep the same seeds, legacy generator algorithm, draw order, bootstrap samples, and threshold calculations. The change isolates the generator rather than changing the statistical procedure.Validation
git diff --checkpass.This concerns the embedding-drift bootstrap paths. It is separate from #1985, which changes the permutation implementation under
legacy/calculations/stattests/utils.py. The full repository suite and end-to-end training benchmarks were not run.