Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ModelDriftMethod creates a binary source label for reference/current embeddings, then uses an unstratified 50/50 split. Even when both populations contain at least two rows, the fixed random split can leave the training set with one class. For example, reference/current sizes 2/8 and 3/4 raise SGDClassifier's single-class error. Training the classifier and evaluating its ROC AUC both require the source classes to remain represented.
Change
Stratify train_test_split by the existing source labels, preserving the 50/50 ratio, shuffle setting, random seed, classifier, and thresholds. This change is independent of the separate fix for using an embedding dimension named target.
Validation
Stratification can change numeric scores on existing datasets because it changes which rows enter each split. This does not provide a statistically reliable drift estimate from arbitrarily small datasets: each population must have enough rows for both splits. The Report plotting layer's independent t-SNE/KDE sample requirements are unchanged; the Report control uses a sufficient sample size.