Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Distance and MMD embedding drift choose bootstrap sample sizes by truncating population-proportional counts. For small or imbalanced inputs, this can produce zero observations for a mean, or one observation for the unbiased MMD statistic whose denominator contains n*(n-1).
The empty mean makes Euclidean distance raise on NaN input; cityblock distance instead produces a NaN threshold and reports no drift. MMD raises ZeroDivisionError. This also affects substantial imbalanced datasets: native Reports fail for reference/current sizes 20/500 with distance and 20/200 with MMD.
Change
Apply the minimum sample count required by each statistic to both bootstrap subsamples: one for distance between means, and two for unbiased MMD. The bootstrap already samples with replacement. Preserve the proportional counts whenever they are large enough, the seeds, the statistic formulas, bandwidths, and quantile settings.
Validation
This fixes the bootstrap subsample domain. It does not relax the original input requirements (MMD still needs at least two observations in each population), solve degenerate bandwidths, or establish reliable inference from arbitrarily small samples. The full repository suite was not run.