Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ClassificationLiftTable converts probability column labels to int in both the binary and multiclass paths. Valid text classes such as cat/dog or Unicode labels raise ValueError before the report can be produced. PredictionData, the result schema, and the renderer already support text labels, and ClassificationPRTable already preserves them.
Change
Use the original class labels as lift-table keys. Leave target binarization, table calculations, rendering, and the existing numeric-key JSON deserialization behavior unchanged.
Validation
This corrects text-label handling in the legacy classification lift-table metric. It does not change lift formulas or the existing normalization of numeric-looking dictionary keys. The full repository and notebook smoke suites were not run.