Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared recommendation preprocessing uses a truthiness check for min_rel_score. An explicitly configured zero threshold is skipped, so items with a zero rating are treated as irrelevant. This can also exclude users who should have relevant feedback and changes the resulting recommendation metrics.
Change
Apply the threshold whenever min_rel_score is not None, including zero. Preserve the existing >= comparison, optional binary conversion, and no-feedback-user policy. Other threshold values and the unconfigured behavior remain unchanged.
Validation
This corrects the handling of an explicit zero threshold in the existing recommendation preprocessing. It does not change ranking, tie handling, metric formulas, or the meaning of a missing threshold. The full repository and notebook smoke suites were not run.