Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
calculate_pr_table and calculate_lift_table recompute true-positive counts from the start of the sorted population at every percentile. This repeatedly scans approximately 20 and 100 overlapping prefixes, respectively, even though each table advances monotonically through the same binary target sequence.
Change
Accumulate TP counts only over the newly included interval. Keep sorting, stable tie order, percentile boundaries, thresholds, rounding and returned rows unchanged. The change uses only the current interval slice rather than allocating a full-length cumulative-count array.
Validation
Local CPU benchmark, one warm-up and five timed calls per case, seeded shuffled binary targets and scores, including each function's sorting but excluding construction/copying of its input list:
These are median local measurements, not end-to-end Report or training benchmarks. Every benchmark returned an identical table representation before and after. Sorting still determines the overall O(N log N) complexity; the change eliminates repeated target-prefix scans. The full repository and notebook smoke suites were not run.