Repository navigation
Conversation
ZNC's znc.in/playback batches are delivered as catch-up and deduped by content per conversation. Behind a bouncer the saved channels are not JOINed; the bouncer's own JOINs rebuild the list. soju.im/webpush is requested alongside draft/webpush. soju search falls back to one request per joined channel and to timestamp context refs. soju.im/ bouncer-networks adds each listed network as its own saved network, bound with BOUNCER BIND before CAP END.
The cap of 20 counted one list at a time, and each -notify line is a list of one, so a bouncer announcing new ids one by one got all of them added. Count what the entry offered before (bouncerSeen) against it, which also bounds bouncerSeen.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bouncer compatibility for ZNC and soju. Every change keys on what the server offers, so nefarious2 and plain ircds see no change.
BATCH znc.in/playback) is delivered as catch-up: appended, counted unread, no notification or highlight. ZNC has no msgids, so a buffered line is known by its time, sender, target and text, counted per conversation; a buffer ZNC keeps across attaches is not shown twice.znc.in/*caps) or soju (BOUNCER_NETID,soju.im/bouncer-networks) the saved channels are never JOINed; the bouncer's own JOINs rebuild the list, so a channel parted from another client stays parted. Same rule as gamja.soju.im/webpushis requested alongsidedraft/webpush. Same command,VAPIDtoken and payload.FAIL SEARCH INVALID_PARAMS inis asked once per joined channel, one after another (soju 0.7 has no labeled-response), and the parts are merged into one page. A server withMSGREFTYPES=timestampis asked for a hit's context by its time.soju.im/bouncer-networks): a login without a network is the control connection. After a SASL login, each network it lists is added as its own saved network, bound withBOUNCER BINDbeforeCAP END. A network the user removes is not added back. Ids are validated, at most 20 per list. The service worker binds too, so replying from a notification reaches the right network.Testing
test/irc/bouncer.ts, plushistorysearch.ts,webpush.tsandcaps.tsupdates. Full suite, lint, typecheck, build and the smoke scenario pass.Notes
serverPassword. Whichever lands second takes that.*playbackmodule, CertFP.