Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5769e22a18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5769e22 to
b19d5c3
Compare
5315b6d to
39ec4fd
Compare
SonarCloud's Quality Gate on PR #41 was failing on New Code Coverage (52.6%, required >= 80%), with zero actual code-smell/bug findings. The gap traced to two files: the four linux_waitable_queue.hpp factory functions were only exercised by tests excluded from coverage collection (no-coverage/fuzz-test tags), and waitable_queue_benchmark.cc is a cc_binary that bazel test coverage can never instrument. Split the epoll-dependent cases out of waitable_queue_integration_test.cc and moved/added the plain factory-function tests into a new linux_waitable_queue_test.cc target that isn't tagged no-coverage, and excluded benchmark sources from the Sonar coverage requirement the same way linux_event_fd.cc already is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
# Conflicts: # udf-runner-cpp/v2/BUILD.bazel # udf-runner-cpp/v2/sonar-project.properties
Even with full line coverage from linux_waitable_queue_test.cc, the Quality Gate still failed (70.7% new coverage, need >= 80%): each factory function's return statement carries a compiler-generated exception-unwind branch for the case where the underlying eventfd() syscall or allocation fails, which cannot be exercised without fault injection. event_fd_factory.cc has the identical one-line forwarding shape and branch. This is the same class of problem the just-merged assert.cc/assert.hpp exclusion documents, so extend the same treatment to these two files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|



Summary
Validation
git diff --checkpassed.Fixes #60