Skip to content

test: add GoogleTest support to v2 - #59

Merged
tkilias merged 12 commits into
mainfrom
feature/gtest_gmock_gbenchmark
Sep 25, 2026
Merged

tkilias merged 12 commits into
mainfrom
feature/gtest_gmock_gbenchmark

Conversation

@tkilias

@tkilias tkilias commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add GoogleTest to the v2 Bazel module and migrate functional v2 tests from custom assert-based mains.
  • Make GoogleMock available for future interaction-based tests without introducing artificial mocks.
  • Document GoogleTest, GoogleMock, and Google Benchmark conventions for v2.
  • Preserve specialized ELF, dynamic-loading, and header-order tests.
  • Address SonarCloud coverage and exception-quality findings.
  • Add the required unreleased changelog entry.

Validation

  • Full v2 Bazel suite: 17/17 tests passed with Bazel 8.3.1.
  • Waitable queue benchmark built and ran successfully.
  • clang-format Bazel validation passed.
  • clang-tidy was not completed because clang-tidy-22 is unavailable in the environment.

Fixes #64

@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 23, 2026 15:14 — with GitHub Actions Waiting
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T15:18:36.991102Z d26a219 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d26a219412

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread udf-runner-cpp/v2/MODULE.bazel
@tkilias
tkilias added this pull request to stack #63 September 24, 2026 15:44
@tkilias
tkilias force-pushed the feature/gtest_gmock_gbenchmark branch from 506e45a to c82cd4a Compare September 24, 2026 17:40
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 24, 2026 17:40 — with GitHub Actions Waiting
Base automatically changed from documentation/coding-style to main September 25, 2026 14:32
@tkilias
tkilias removed this pull request from stack #63 September 25, 2026 14:52
@tkilias
tkilias added this pull request to stack #69 September 25, 2026 14:52
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 15:12 — with GitHub Actions Waiting
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 15:24 — with GitHub Actions Waiting
@tkilias
tkilias deployed to v2-fuzzing-pr-approval September 25, 2026 15:36 — with GitHub Actions Active
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 15:47 — with GitHub Actions Waiting
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 16:01 — with GitHub Actions Waiting
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 16:16 — with GitHub Actions Waiting
@sonarqubecloud

Copy link
Copy Markdown

@tkilias
tkilias merged commit 821ed58 into main Sep 25, 2026
24 of 25 checks passed
@tkilias
tkilias deleted the feature/gtest_gmock_gbenchmark branch September 25, 2026 16:29

This branch is waiting to be deployed

1 waiting deployment
v2-fuzzing-pr-approval — e2391ea0 Waiting Sep 25, 2026 by tkilias via pr_approval #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GoogleTest, GoogleMock, and Google Benchmark support to v2

1 participant