Skip to content

#57: Define and enforce v2 C++ coding style - #67

Merged
tkilias merged 6 commits into
mainfrom
documentation/coding-style
Sep 25, 2026
Merged

tkilias merged 6 commits into
mainfrom
documentation/coding-style

Conversation

@tkilias

@tkilias tkilias commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add public v2 C++ coding-style guidance and enforce the documented naming policy.
  • Configure clang-tidy through the repository wrapper and make its executable configurable.
  • Keep style-only sources out of the coverage gate.

Validation

  • Focused queue and eventfd tests pass on the stacked base.
  • git diff --check passed.

Fixes #57

@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 10:33 — with GitHub Actions Waiting
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T10:38:12.465989Z a4c3360 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4c3360d24

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread udf-runner-cpp/v2/tools/clang-tidy/.clang-tidy
@tkilias
tkilias added this pull request to stack #68 September 25, 2026 12:57
sgn4sangar
sgn4sangar previously approved these changes Sep 25, 2026
kratz00
kratz00 previously approved these changes Sep 25, 2026
Base automatically changed from refactor/waitable-queue to main September 25, 2026 13:52
@tkilias
tkilias dismissed stale reviews from kratz00 and sgn4sangar September 25, 2026 13:52

The merge-base changed after approval.

@tkilias
tkilias force-pushed the documentation/coding-style branch from a4c3360 to de88fb2 Compare September 25, 2026 13:52
@tkilias
tkilias requested a deployment to v2-fuzzing-pr-approval September 25, 2026 13:52 — with GitHub Actions Waiting
@sonarqubecloud

Copy link
Copy Markdown

@tkilias
tkilias merged commit 2ede48f into main Sep 25, 2026
25 of 26 checks passed
@tkilias
tkilias deleted the documentation/coding-style branch September 25, 2026 14:32

This branch is waiting to be deployed

1 waiting deployment
v2-fuzzing-pr-approval — de88fb27 Waiting Sep 25, 2026 by tkilias via pr_approval #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define and enforce v2 C++ coding style

3 participants