Repository navigation
fix(data): settle mechanical catalog-submissions findings - #920
Conversation
Seven passive Marshall cabinets move their inputs from line to speaker-level, and nineteen Marshall footswitch jacks from line to expression. The Thrash v2 pair gains its firmware USB-C port, and two Elektron packs lose ingest-date releaseDates. Settles catalog-submissions 77, 95, 96, 97, 98, most of 91, and 22. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UsMUqfW3Tnod96zTZJfkfT
🦋 Changeset detectedLatest commit: 0b694b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: existential-engineering/catalog/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (31)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. WalkthroughMarshall connection types, Mackie firmware-port records, and Elektron release-date metadata were updated. A catalog patch changeset documents these updates. ChangesCatalog data updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The catalog updates follow the documented type conventions, the firmware ports remain available to catalog consumers, and missing release dates are supported. No merge-blocking issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
the
ready-for-review
2 participants
Description
This PR fixes the catalog-submissions inbox findings that can be settled from data already in the repo and the evidence already in each issue.
line→speaker-level(catalog-submissions#95, chore: version packages #96, hardware: add Chroma Console #97). Seven cabinets and 13 ports: 1936, 1936V, 1960AV, 1960B, 2551AV, 2551BV and Studio Vintage 2x12. The 1936 and 1960B were not in the review findings, but they have the same defect.speaker-level-auditmissed all seven because the port names ("Input 1 (Mono / Stereo Left)") never say "speaker". These were the only Marshall cabinets still online.line→expression(catalog-submissions#98, and 19 of the 21 in hardware: update Tonverk #91). This follows the footswitch/expression rule in CLAUDE.md. Two ports stay out, pending the manual: the combined "Aux In / Footswitch" minijacks ondsl1-comboanddsl20-head.USB-C (Firmware Update Only)port that the owner's manual documents. It is modelledbidirectional/digital/usb, following the precedent ofblack-lion-audio-revolution-expandintellijel-scales.releaseDate, years after release. The dates are removed rather than guessed.The Marshall io in open #913 matches main, so these edits change only
typelines. If #913 merges first, expect at most a trivial rebase.Type of Change
Checklist
pnpm validateand it passeshpI added or changed names its source in the description (n/a)Additional Notes
IO keys were assigned with
pnpm assign-ids, and Prettier reports the changed files clean. A changeset is included.🤖 Generated with Claude Code
https://claude.ai/code/session_01UsMUqfW3Tnod96zTZJfkfT
Generated by Claude Code
Summary by CodeRabbit