Repository navigation
fix(data): rename MuseScore to MuseScore Studio, add its macOS bundle id - #933
Conversation
… id (AUREO-1311) The desktop app is MuseScore Studio from 4.3. Keep "MuseScore" as a search term, since it is still the ecosystem's umbrella name. identifiers.bundle (org.musescore.MuseScore, unchanged upstream through 4.7.5) resolves the standalone format, so Studio matches the entry on macOS by identifier before the name score is consulted, for builds that still report the scanner name "MuseScore" as well as new ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TxMVXrJziUWrnvcksQgLM1
🦋 Changeset detectedLatest commit: ebf85ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. WalkthroughThe catalog entry is renamed to MuseScore Studio. It uses “MuseScore” as a search term and adds the macOS bundle identifier ChangesMuseScore Studio catalog
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: 🔵 Low · up to This renames MuseScore to MuseScore Studio and adds a macOS bundle ID, so macOS matching should keep working. Older Windows and Linux Studio builds may stop recognizing the entry until the updated Studio release ships. Merge once that release is out, as the PR description already requests. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
|
I searched the open PRs and found no fix. I can't open one from this session, because it may only push to this PR's branch, and dependency changes would widen this PR. Here is the fix I tested locally. With these overrides, --- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -27,6 +27,10 @@
# - esbuild >=0.28.1: vite/tsx pull esbuild@0.28.0, vulnerable to
# GHSA-g7r4-m6w7-qqqr (arbitrary file read via dev server). Patched in 0.28.1.
+# - shell-quote >=1.11.0: @changesets/cli > launch-editor pulls 1.10.0,
+# GHSA-pqg4-j6r4-53mv (critical). Patched in 1.11.0.
+# - source-map-js >=1.2.2: vitest > vite > postcss pulls 1.2.1,
+# GHSA-68fv-2mgg-jv7q (event-loop DoS). Patched in 1.2.2.
#
@@ -47,3 +51,5 @@
overrides:
vite: ">=8.0.16 <9"
esbuild: ">=0.28.1"
+ shell-quote: ">=1.11.0"
+ source-map-js: ">=1.2.2"The lockfile change also needs regenerating with As the PR body says, this PR must still not merge before the racks scanner rename ships. Generated by Claude Code |
Fixes AUREO-1311
Description
The desktop notation app has been MuseScore Studio since 4.3. This PR is the catalog half of the five-site rename in AUREO-1311. The other four sites are changed in existential-engineering/racks#3781: the three scanner tables and
packages/lib/src/constants/daws.ts.Changes in
data/software/muse-group-musescore.yaml:name: MuseScore→name: MuseScore StudiosearchTerms:MuseScore Studio→MuseScore, because "MuseScore" is still the umbrella name for the ecosystem.MuseScore 4andMuseHubstay.identifiers.bundle: org.musescore.MuseScore. Upstream sets it fromMUSE_APP_NAME_MACHINE_READABLE_COMPAT, and it is unchanged through v4.7.5 (seeversion.cmakeat that tag). Under the identifier fallback rule,bundlefillsstandalone, which is the entry's only format. Ableton Live and Bitwig use the same pattern.idand versions are unchanged. The only listed version, 4.7.5, shipped as MuseScore Studio, so there is no pre-4.3 history to keep.Why the identifier is part of the rename
Studio tries an identifier match (heuristic 2) before it falls back to the name score, and the macOS DAW scanner reports the bundle id as the identifier. With this id in the catalog, macOS matches the entry on every Studio build, whether its scanner reports the old name
MuseScoreor the new one. Without the id,MuseScoreagainstMuseScore Studioscores 0.85, andvalidateMatchrejects it (measured in the issue).On Windows and Linux the scanner's identifier is not a stable id: it is the uninstall display name on Windows and the
.desktopfile name on Linux. On those platforms the name stays the match key.Merge order
existential-engineering/racks#3781 merges first. Merge this PR only once a Studio release that carries it has shipped. Every installed Studio downloads the newest
catalog.sqlite:Even in the right order, Studio builds older than racks#3781 will stop matching MuseScore on Windows and Linux once this publishes, because their scanner still says
MuseScore. macOS is covered by the identifier. Merging accepts that cost, as AUREO-1311's "both sides move together" plan implies.Type of Change
Checklist
pnpm validateand it passes (alsopnpm typecheckandpnpm format:check)version.cmakeandsrc/app/CMakeLists.txt.hpI added or changed names its source in the descriptionAdditional Notes
What changes in racks#3781:
name: "MuseScore Studio"in the Linux, macOS and Windows scanner tables and inpackages/lib/src/constants/daws.tsapp_name_pattern/appNamePatternis widened to^MuseScore( Studio)?( \d+)?$, with a Rust test.Upstream facts behind the pattern, checked at v4.7.5:
MuseScore 4.app;buildscripts/ci/macos/package.shhas a TODO to rename it (Finish renaming to Studio, now that there is a major version number change musescore/MuseScore#32235). Upstreammainalready packagesMuseScore Studio.app, with bundle idorg.musescore.MuseScoreStudio5..desktopfile'sName=isMuseScore Studio 4.7, which the Linux table'smusescoresubstring already matches.The red
auditcheck comes from dependency advisories already present onmainand is not caused by this PR. The tested fix is in the comment below.🤖 Generated with Claude Code
https://claude.ai/code/session_01TxMVXrJziUWrnvcksQgLM1
Summary by CodeRabbit