Skip to content

feat(schema): accept IDR prices (AUREO-1223) - #954

Merged
jeffreylouden merged 1 commit into
mainfrom
fix/aureo-1223/idr-currency
Oct 17, 2026
Merged

jeffreylouden merged 1 commit into
mainfrom
fix/aureo-1223/idr-currency

Conversation

@jeffreylouden

@jeffreylouden jeffreylouden commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Fixes AUREO-1223

What

  • schema/currencies.yaml: add IDR, alphabetical between HUF and INR
  • schema/json/*.json: regenerated with pnpm generate:schemas (IDR added to each price-currency enum, nothing else moved)
  • schema/CONTEXT.md: regenerated by the pre-commit hook

racks' packages/lib currency list and the pipeline's extraction enum already carry IDR, so an extracted rupiah price failed validation here. Nothing in racks changes.

Heads up: pnpm validate is red on main, not from this PR

data/hardware/aguilar-db-700.yaml line 127 has connection: iec on its power input, which fails E130 (every other mains inlet in the corpus is iec-c14 / iec-c20 etc.). It came in with the Aguilar import. That will fail this PR's validate job too. It is left alone here because the connector should come from the DB 700 manual rather than a guess, per the I/O conventions.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TYAfks1xdhCJbQ3fFXChue


Generated by Claude Code

Summary by CodeRabbit

  • New Features
    • Added support for Indonesian rupiah (IDR) prices across accessory, content, hardware, and software catalog entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYAfks1xdhCJbQ3fFXChue
@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5a31f6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
catalog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the schema Changes to catalog schemas label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: existential-engineering/catalog/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f90f5514-e506-4feb-8f57-4839c882f497
📥 Commits

Reviewing files that changed from the base of the PR and between b0cba2b and 5a31f6e.

📒 Files selected for processing: 7
  • .changeset/aureo-1223-idr-currency.md
  • schema/CONTEXT.md
  • schema/currencies.yaml
  • schema/json/accessory.json
  • schema/json/content.json
  • schema/json/hardware.json
  • schema/json/software.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The currency allowlist and JSON price schemas now accept Indonesian rupiah (IDR). A catalog patch changeset records the update.

Changes

IDR currency support

Layer / File(s) Summary
Add IDR to the currency list
schema/currencies.yaml, schema/CONTEXT.md
The valid currency list and its context documentation now include IDR.
Add IDR to price schemas
schema/json/*, .changeset/aureo-1223-idr-currency.md
Price currency enums now include IDR for accessory, content, hardware, and software schemas. The changeset records the catalog patch.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 5a31f

IDR prices are accepted by the catalog schemas and validator, while unlisted currencies remain rejected. No actionable merge risk is indicated by these changes.

### Architecture Summary

Architecture risk: 🔵 Low · up to 5a31f

The change affects 1 system.

Changed systems: schema

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — schema (service) was modified; 6 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in schema/CONTEXT.md: Added IDR to the listed currencies.
  • observed — Modified behavior in schema/currencies.yaml: Added IDR to the list of valid currency codes.
  • observed — Modified behavior in schema/json/accessory.json: Adds IDR to the allowed currency codes for version-level prices.
  • observed — Modified behavior in schema/json/accessory.json: Adds IDR to the allowed currency codes for product-level prices.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: accepting IDR prices in the schema. The issue reference is relevant.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

validate is red here, and it is not this PR's change.

The one error is E130 on data/hardware/aguilar-db-700.yaml:127: its power input has connection: iec, which is not in schema/io-connections.yaml (the vocabulary has iec-c6, iec-c8, iec-c14, iec-c20). It arrived with the Aguilar import (#947's sibling), and validate is failing on main at b0cba2b for the same reason. Reproduced locally: unmodified main exits 1 on exactly this error, and this branch adds nothing else.

No fix PR exists yet. I have not ported a guess. The right value comes from the DB 700 manual, most likely iec-c14 like every other rack amp in the corpus, but this repo's I/O rules say the connector comes from the maker, not from inference. Once the entry is fixed on main, a merge of main into this branch should turn it green. I cannot re-run the job from this session.


Generated by Claude Code

@jeffreylouden
jeffreylouden merged commit d1660d8 into main Oct 17, 2026
8 of 9 checks passed
@jeffreylouden
jeffreylouden deleted the fix/aureo-1223/idr-currency branch October 17, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

schema Changes to catalog schemas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants