Repository navigation
vpc support for exo compute instance create - #947
Merged
Merged
Conversation
pierre-emmanuelJ
approved these changes
Nov 2, 2026
pierre-emmanuelJ
left a comment
pierre-emmanuelJ
left a comment
Member
There was a problem hiding this comment.
Looks good, the NAME|ID[,ipv4=IP] format leaves room for ipv6 later. A few nits below, nothing blocking.
| - kms: add `--encryption-algorithm` to `exo kms crypto encrypt` and `decrypt`, and `--source-encryption-algorithm` and `--dest-encryption-algorithm` to `reencrypt`, to use RSA keys | ||
| - kms: show the key spec in `exo kms key show` and `exo kms key list` | ||
| - dbaas: add `exo dbaas acl list` for Kafka and OpenSearch, `exo dbaas acl create` and `delete` for Kafka, and Kafka and OpenSearch support in `exo dbaas acl show` (#923) | ||
| - compute: add `--vpc` and `--vpc-subnet` to `exo compute instance create` to attach an instance to VPC Subnets at creation |
Member
There was a problem hiding this comment.
Nit: Missing the PR number at the end, (#947).
| } | ||
|
|
||
| // resolveCreateInstanceVPC builds the VPC attachment of an instance creation | ||
| // request from a VPC NAME|ID and a list of NAME|ID[:IPV4] subnet specs. |
Member
There was a problem hiding this comment.
The comment still says NAME|ID[:IPV4], the format is now NAME|ID[,ipv4=IP].
| } | ||
| } | ||
|
|
||
| if c.VPC != "" || len(c.VPCSubnets) > 0 { |
Member
There was a problem hiding this comment.
validateVPCFlags already ran at the top of CmdRun, so at this point both flags are either set or empty. if c.VPC != "" is enough, and the second validateVPCFlags call inside resolveCreateInstanceVPC (l.393) could go too. The error-case tests would then call validateVPCFlags directly.
aureliar8
force-pushed
the
aureliar8/create-instance-with-vpc
branch
from
November 2, 2026 15:56
357badd to
3f1d511
Compare
pierre-emmanuelJ
approved these changes
Nov 2, 2026
quentinalbertone
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add VPC support to
exo compute instance createto be able to directly create instance attached to VPC subnetsExample usage
=> This show the two way to attach an instance to a subnet, either by specifying the ipv4 to use or by letting exoscale decide. (In a few month when ipv6 is supported you'll also be able to do
my-second-subnet,ipv4=10.0.0.5,ipv6=<something>ormy-second-subnet,ipv6=<something>)[ch198689]
Checklist
(For exoscale contributors)
CHANGELOG.md)Testing