fix: accept a comma-delimited list in req.acceptsCharsets - #7451
Closed
marceli1404 wants to merge 1 commit into
Closed
fix: accept a comma-delimited list in req.acceptsCharsets#7451marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
3 tasks
Contributor
|
As far as I can tell, the docs are wrong. Comma delimited string has not been supported since cec0c06, according to #6936 (comment). You'll find more details and an attempt at fixing the docs in #7452. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
req.acceptsCharsets()silently ignores the documented comma-delimited form. The jsdoc (added by merged PR #6088) documents:...but the implementation passes the arguments straight through to
accepts().charsets(...), which never splits commas. So a client following the documented API gets a hardfalse:Fix
Expand comma-delimited args before passing them along, so
req.acceptsCharsets('iso-8859-1, utf-8')behaves like the documented multi-arg form:Verification
npm test(mocha, full suite): 1262 passing, 0 failing.eslintclean on the changed files.