Skip to content

chore(deps): bump zip to 9.0 - #821

Merged
ptondereau merged 1 commit into
masterfrom
chore/bump-zip-9
Oct 15, 2026
Merged

ptondereau merged 1 commit into
masterfrom
chore/bump-zip-9

Conversation

@ptondereau

Copy link
Copy Markdown
Member

Description

Supersedes #818, whose Windows build fails because zip 9 returns ZipResult<Cow<str>> from ZipArchive::file_names() (zip-rs/zip2#789, job). The build script now returns that error and keeps the devel pack name as an owned String.

Checklist

@ptondereau
ptondereau marked this pull request as ready for review October 15, 2026 16:51
@ptondereau
ptondereau merged commit 16b2a4a into master Oct 15, 2026
73 checks passed
@ptondereau
ptondereau deleted the chore/bump-zip-9 branch October 15, 2026 16:52
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38772260742

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 75.503%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15100
Covered Lines: 11401
Line Coverage: 75.5%
Coverage Strength: 53.81 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Oct 15, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 51 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 51 untouched benchmarks


Comparing chore/bump-zip-9 (71888e9) with master (7d00750)

Open in CodSpeed

@ext-php-rs-release ext-php-rs-release Bot mentioned this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants