Assesments uploads should be case insensitive - #145
Merged
Conversation
CSV autoschedule now matches existing assessments by appId case-insensitively using an anchored MongoDB regex, so a CSV row with 'app-001' resolves to an existing 'APP-001' assessment instead of creating a duplicate. Adds a test verifying lowercased appIds match uppercase existing ones.
… action Allow the assessor to close a finding in dev, staging, or prod when saving a passing retest, with the choice taking precedence over the system verificationOption. Add severity adjustment on retest with a required annotation when changed, recording the change in the same chSevTable format the remediation team uses. Add an on-failure option to either close the verification (default) or send it back to the remediation team. Adds unit tests for the close-environment and severity-change helper logic.
Admins can now reopen a finalized assessment from the Finalize page. Reopen resets the assessment workflow, clears the completed date, and returns the status to In Progress; any vulnerabilities that were Closed are moved back to Open. An email notification is sent on reopen. The action is restricted to administrators and only allowed when the assessment is currently finalized. Also keeps finalized assessments in the assessment queue for a 30-day grace period via a shared nonCompletedOrRecentlyFinalized query clause, so recently finalized assessments remain visible to find and reopen.
The peer review queue's Download Report button was the only DownloadReport caller not passing a format, so it fell through to selectVariant's PDF-preferring default. Reviewers mark the report up, so hand them the editable Word document. Reports stored before variants existed are unaffected: getEffectiveVariants synthesizes a single variant from getFileType(), which defaults to "docx", so format=docx matches it and serves the same file as before. Also renames downPdf to downloadReport, which is what it now does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.