Skip to content

Fix messages being sent as two separate zmq messages - #412

Merged
RalphSteinhagen merged 2 commits into
mainfrom
ian/fix-partial-message
Oct 29, 2026
Merged

Fix messages being sent as two separate zmq messages#412
RalphSteinhagen merged 2 commits into
mainfrom
ian/fix-partial-message

Conversation

@the-argus

@the-argus the-argus commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just a typo, but with some weird results. Also includes bumping the workflows to use the compiler versions we now use in the gnuradio docker image.

(Done because blocking CI for fair-acc/opendigitizer#519 which in turn was blocking my task fair-acc/opendigitizer#502)

@the-argus
Fix messages being sent as two separate zmq messages
5c56198 
Signed-off-by: Ian McFarlane <ian.mcfarlane@kdab.com>
@the-argus
the-argus deployed to configure coverage October 28, 2026 23:25 — with GitHub Actions Active
@the-argus
the-argus force-pushed the ian/fix-partial-message branch from 3f31d03 to 9fb90df Compare October 28, 2026 23:32
@the-argus
the-argus deployed to configure coverage October 28, 2026 23:32 — with GitHub Actions Active
@the-argus
the-argus force-pushed the ian/fix-partial-message branch from 9fb90df to 22cc8ce Compare October 29, 2026 00:09
@the-argus
the-argus deployed to configure coverage October 29, 2026 00:09 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 00:09 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 00:09 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 00:09 — with GitHub Actions Active
@the-argus
Bump CI compiler versions to equal the latest gnuradio docker image
1d2c066 
Fix fallout with emscripten version bumping, and clang.

Also increase the wait time for the load test because the gcc coverage
build is much slower now, for some reason.

Signed-off-by: Ian McFarlane <ian.mcfarlane@kdab.com>
@the-argus
the-argus force-pushed the ian/fix-partial-message branch from 22cc8ce to 1d2c066 Compare October 29, 2026 16:48
@the-argus
the-argus deployed to configure coverage October 29, 2026 17:25 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 17:25 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 17:25 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 17:25 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 17:25 — with GitHub Actions Active
@the-argus
the-argus deployed to configure coverage October 29, 2026 17:25 — with GitHub Actions Active
@sonarqubecloud

sonarqubecloud Bot commented Oct 29, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@RalphSteinhagen
RalphSteinhagen merged commit 1e378d6 into main Oct 29, 2026
10 of 11 checks passed
@RalphSteinhagen
RalphSteinhagen deleted the ian/fix-partial-message branch October 29, 2026 20:06

This branch was successfully deployed

1 active deployment
configure coverage — 1d2c0664 Deployed Oct 29, 2026 by the-argus via emscripten | Debug #1322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@the-argus @RalphSteinhagen