feat!: preserve array field identity with signals - #12
Open
LouisHaftmann wants to merge 1 commit into
Open
LouisHaftmann wants to merge 1 commit into
LouisHaftmann wants to merge 1 commit into
Conversation
Replace positional mutation mirroring with store identity, batched writes, and React/Vue subscriptions. Preserve positional primitive fields and reset, keyed source refreshes, validation timing, and opaque values. Closes #4 BREAKING CHANGE: Writes are microtask-batched, field keys are opaque, and reactive helpers use @solidjs/signals. Created with AI. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array edits could leave fields attached to the wrong row. Object and array fields now keep their keys, dirty state, and errors when their values move, using stable
@solidjs/signalsstore identities.Scope
setData(recipe).useSyncExternalStoreand Vue through flushed notifications. Preserve input focus and selection during row moves.Breaking changes: writes are microtask-batched, field keys are opaque, and the
/reactiveexports use signals. The internalform['~'].flush()forces values current; validation remains asynchronous. Migration notes are in README.Verification
Run on Node 24.13.1:
pnpm test: 91 tests pass, including type assertions.pnpm type-check: passes.pnpm --filter './packages/**' -r run type-check: all three library packages pass.pnpm lint:ci: passes.pnpm build: all three packages build ESM, CJS, and declarations.Reviews
Findings overlap across reviews. Follow-up reviews report no remaining findings.
Screenshots
Temporary test page exercising both adapters at mobile width:
Issues
Closes #4
Needs attention
2.0.0-rc.6. That release has no public reverse-path lookup, so paths are derived from live proxy identities. Itsdeep()misses nested edits after a sibling edit; core tracks reads through the tree instead. Both have focused behavioral coverage.vue-tsc@3.3.9cannot load TypeScript 7'slib/tscexport. Both dependencies are unchanged from the base commit. Library checks and required CI do not use this command.