Skip to content

fix(reusable-ci): install Playwright browsers as the runner user, not root #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdfalk merged 1 commit into from
Oct 27, 2026
Merged

fix(reusable-ci): install Playwright browsers as the runner user, not root #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/guid-index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@
"path": ".github/workflows/reusable-ci.yml",
"guid": "reusable-ci-2025-09-24-core-workflow",
"title": "Reusable CI Workflow",
"version": "1.19.2",
"version": "1.19.3",
"header_path": ".github/workflows/reusable-ci.yml",
"path_mismatch": false
},
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/reusable-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# file: .github/workflows/reusable-ci.yml
# version: 1.19.2
# version: 1.19.3
# guid: reusable-ci-2025-09-24-core-workflow
# last-edited: 2026-10-21
# last-edited: 2026-10-27

name: Reusable CI Workflow

Expand Down Expand Up @@ -975,7 +975,13 @@ jobs:
dir="${FRONTEND_DIR//\'/}"
dir="${dir//\"/}"
cd "${dir:-.}"
sudo npx playwright install --with-deps chromium webkit
# System libraries need root; the browser binaries must NOT be installed
# with sudo. `sudo npx playwright install` writes to /root/.cache/ms-playwright
# (sudo resets HOME), but the E2E step below runs as the runner user and
# looks in ~/.cache/ms-playwright, so every test failed with
# "Executable doesn't exist". Install deps as root, browsers as the runner.
sudo env "PATH=$PATH" npx playwright install-deps chromium webkit
npx playwright install chromium webkit
shell: bash

- name: Run E2E tests
Expand Down
3 changes: 3 additions & 0 deletions changelog.d/20261027_playwright_install_user_cache.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- reusable-ci: Playwright browsers are now installed as the runner user (only the system dependencies use sudo), so the E2E step finds them in the runner cache instead of failing with "Executable doesn't exist".
Loading