Adopt Buf and publish client SDKs through BSR - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the custom protobuf generation scripts with pinned Buf remote plugins, schema linting, and compatibility checks. Publish the public schema to BSR during deployment and use BSR-generated SDKs for client distribution, removing the local Go module, bindings, and tests.
Move the service to
fanscore.optimizer.v1, renamehandler.pytogrpc_service.py, and update Python imports and health probes. Keep vendored OR-Tools schemas and OR-Tools' own Python messages. Focus the README on local development and document the contract inproto/buf.md.Clients using
optimizer.v1must migrate to the new namespace alongside the server.Validation: 29 Python tests; Buf lint, format, generated-output and BSR compatibility checks; Ruff; actionlint; YAML and Nix checks; Python wheel contents verified. Docker build was not run locally.