Client consent screen - #225
Open
NonSwag wants to merge 8 commits into
Open
Conversation
NonSwag
force-pushed
the
feat/onboarding-screen
branch
from
August 15, 2026 10:13
db7364e to
a3550c2
Compare
NonSwag
force-pushed
the
feat/onboarding-screen
branch
from
August 15, 2026 10:29
a3550c2 to
24544f6
Compare
NonSwag
commented
Aug 18, 2026
| @Contract(mutates = "io") | ||
| public void persist() throws RuntimeException { | ||
| final var properties = readOrEmpty(file); | ||
| if (properties == null) throw new IllegalStateException("Metrics config has not been initialized"); |
Comment on lines
+271
to
+288
|
|
||
| @Override | ||
| public boolean equals(final Object object) { | ||
| if (this == object) return true; | ||
| if (!(object instanceof final SimpleConfig that)) return false; | ||
| return enabled == that.enabled | ||
| && additionalMetrics == that.additionalMetrics | ||
| && debug == that.debug | ||
| && submitMetrics == that.submitMetrics | ||
| && errorTracking == that.errorTracking | ||
| && firstRun == that.firstRun | ||
| && Objects.equals(serverId, that.serverId); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(serverId, enabled, additionalMetrics, debug, submitMetrics, errorTracking, firstRun); | ||
| } |
Member
Author
There was a problem hiding this comment.
equals and hashCode should not be overridden
Member
Author
There was a problem hiding this comment.
still dont like it; also the javadocs are horrific
Comment on lines
+77
to
+78
| final var start = preSubmissionStart(); | ||
| if (!lifecycleManaged && !start) return; |
Member
Author
There was a problem hiding this comment.
guard preSubmissionStart with lifecycleManaged; otherwise the onboarding message is printed multiple times
|
|
||
| @Override | ||
| public void shutdown() { | ||
| public synchronized void shutdown() { |
| if (handler != null) handler.uncaughtException(thread, error); | ||
| } | ||
|
|
||
| // todo: revise |
Member
Author
There was a problem hiding this comment.
todo still valid: hate it still
| import java.util.stream.Collectors; | ||
|
|
||
| @ApiStatus.Internal | ||
| // todo: revise |
| plugins { | ||
| id("net.fabricmc.fabric-loom") version "1.15-SNAPSHOT" | ||
| kotlin("jvm") | ||
| //kotlin("jvm") |
Member
Author
There was a problem hiding this comment.
don't forget to un-uncomment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.