Skip to content

Unify contributor and agent guidance#947

Merged
dahlia merged 1 commit into
fedify-dev:mainfrom
dahlia:docs/contributing.md
Jul 18, 2026
Merged

Unify contributor and agent guidance#947
dahlia merged 1 commit into
fedify-dev:mainfrom
dahlia:docs/contributing.md

Conversation

@dahlia

@dahlia dahlia commented Jul 18, 2026

Copy link
Copy Markdown
Member

Fedify's contribution rules had grown across AGENTS.md and CONTRIBUTING.md. Much of the material overlapped, but each document also contained details that the other audience was expected to know. This made the applicable rules depend on which entry point a contributor or coding agent happened to read, and it gave duplicated guidance room to drift as the repository changed.

This change treats CONTRIBUTING.md as the shared guide for both people and coding agents. AGENTS.md and CLAUDE.md remain as conventional discovery points, but both are symbolic links to that guide. The repository therefore keeps the filenames expected by agent tooling without maintaining separate copies of the same policy.

The consolidated guide is organized around the contribution workflow rather than around a package inventory. Package lists change often and were already maintained in the “Packages” section of README.md, so repeating them in contributor documentation made stale information more likely without helping contributors make decisions. The guide now points readers to the existing inventory and keeps its own focus on policies, development tasks, testing boundaries, and review expectations that apply across packages.

The rewrite also makes the Markdown rules consistent with the rest of the repository. It avoids bold text as structural emphasis and tells issue and pull request authors to keep prose paragraphs on one source line, then pass the description through hongdown --stdin --no-line-width. Describing the command directly avoids a numeric line-width rule that some language models interpreted as an instruction to insert line breaks.

The vocabulary workflow had a failure mode that the general testing guidance did not cover: generated-output snapshots are stored separately for Deno, Node.js, and Bun. The aggregate update command is therefore documented in CONTRIBUTING.md, packages/vocab-tools/README.md, and .agents/skills/add-vocab/SKILL.md so that contributors encounter it whether they begin from the general workflow, the package, or the task-specific guide. The vocabulary section also states that generated types are exported automatically, which keeps contributors from editing generated code or adding redundant exports.

Consolidate human and coding-agent instructions in CONTRIBUTING.md, with
AGENTS.md and CLAUDE.md linking to the shared guide.

Remove volatile package inventories, align the Markdown and issue-writing
rules, and document multi-runtime vocabulary snapshot updates in the guide,
the vocab-tools README, and the add-vocab skill.

Assisted-by: Codex:gpt-5.6-sol
@dahlia dahlia added this to the Fedify 2.4 milestone Jul 18, 2026
@dahlia
dahlia requested a review from sij411 July 18, 2026 08:44
@dahlia dahlia self-assigned this Jul 18, 2026
@dahlia
dahlia requested a review from 2chanhaeng as a code owner July 18, 2026 08:44
@netlify

netlify Bot commented Jul 18, 2026

Copy link
Copy Markdown

Deploy Preview for fedify-json-schema canceled.

Name Link
🔨 Latest commit 01f773f
🔍 Latest deploy log https://app.netlify.com/projects/fedify-json-schema/deploys/6a5b3d0900c67600083d5119

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Contribution documentation was rewritten with updated development, testing, AI usage, repository maintenance, documentation, pull request, and release guidance. Snapshot instructions were added for all supported runtimes, and related tooling metadata and links were updated.

Changes

Contribution Guidance

Layer / File(s) Summary
Authoring and generated-output instructions
.hongdown.toml, CLAUDE.md, .agents/skills/add-vocab/SKILL.md, packages/vocab-tools/README.md
Repository authoring exclusions and links were updated, while skill and vocabulary-tool documentation now describes multi-runtime snapshot updates.
Contribution workflow and testing rules
CONTRIBUTING.md
Development setup, AI contribution rules, runtime-compatible testing, Cloudflare Workers constraints, dependency management, and test tasks were reorganized and expanded.
Repository changes and release procedures
CONTRIBUTING.md
Guidance for adding repository components, documentation, pull requests, commits, changelogs, releases, and final verification was revised.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested labels: type/documentation

Suggested reviewers: sij411, 2chanhaeng

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: consolidating contributor and agent guidance.
Description check ✅ Passed The description is clearly aligned with the changeset and explains the consolidation and documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates and updates the project's contribution guidelines and documentation. Key changes include a major rewrite of CONTRIBUTING.md to align rules for both human contributors and AI coding agents, updating references in CLAUDE.md and AGENTS.md, and adding instructions for updating multi-runtime snapshots in .agents/skills/add-vocab/SKILL.md and packages/vocab-tools/README.md. The review feedback suggests minor Markdown formatting improvements by removing unnecessary backslash escapes in references to AI_POLICY.md.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CONTRIBUTING.md`:
- Around line 592-604: Update the two quadruple-tilde fenced code blocks in the
commit-message example to include the text language identifier after the opening
fence, preserving their contents and closing fences.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b0969292-19b8-4a84-9492-069e8fb99d07

📥 Commits

Reviewing files that changed from the base of the PR and between 2d46cdb and 01f773f.

📒 Files selected for processing (7)
  • .agents/skills/add-vocab/SKILL.md
  • .hongdown.toml
  • AGENTS.md
  • AGENTS.md
  • CLAUDE.md
  • CONTRIBUTING.md
  • packages/vocab-tools/README.md

Comment thread CONTRIBUTING.md
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sij411 sij411 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great.

@2chanhaeng 2chanhaeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be going beyond the scope of this PR, but I think one of the reasons CONTRIBUTING.md is so bloated is that it's all integrated instead of being separated by context. I'm certain that if CONTRIBUTING.md were split up by package, both humans and AI would be able to focus on the specific information they need for each context.

Comment thread CONTRIBUTING.md
@dahlia
dahlia merged commit f1c00f2 into fedify-dev:main Jul 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants