Repository navigation
Conversation
Refs MEMOH-232
Refs MEMOH-232
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0521c23504
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| · font-medium (450) → labels, button text, badges, small/inline titles, emphasis, | ||
| and text typed into Input / Textarea (placeholder included) | ||
| · font-normal (360) → body, descriptions, read-only field values */ |
There was a problem hiding this comment.
The new default field-weight mapping is documented only in this CSS comment, while AGENTS.md’s Typography section still explicitly assigns field values and placeholders to font-normal. This leaves the repository’s authoritative design contract contradicting the newly changed Textarea and Select defaults, so subsequent component work following that contract would reintroduce the inconsistency this commit fixes. Update the contract to document the default-size field mapping and its intentional size exceptions; AGENTS.md requires cross-cutting decisions to be recorded there.
AGENTS.md reference: AGENTS.md:L868-L871
Useful? React with 👍 / 👎.
|
转回草稿，暂不合并。 走查发现本 PR 是半个修复：Details 与 Subject 对齐了，但下拉框收起时改为 450 后，与展开后的选项（菜单项 360、字间距 -0.14px、行高 18px）又出现新的不一致。 根因是 Input / Textarea / SelectTrigger / SelectItem 各自写死字号、字重、字间距、行高，没有一个共享的「控件文字」档位。计划在组件库整体改造时统一处理（需先定该档位字重用 360 还是 450），详见 MEMOH-232。 |
Summary
表单里三种字段控件的默认字号、字重不一致：单行输入框（Input）是 14px / 450，多行输入框（Textarea）默认 13px / 360，下拉框（Select 触发器）默认 13px / 360。同一个表单里 Subject、Details、下拉框的值与 placeholder 三种观感，并排时很明显。
经 UI 负责人确认以 Input 为准，把另外两个的默认尺寸对齐到 14px / 450：
Textarea：default档text-label→text-control font-medium。sm（目前无调用方）与lg（本来就是 14px）不动。selectTriggerClass：data-[size=default]改为text-control font-medium。sm/lg档、下拉展开后的选项（menu item）不动。style.css字重角色说明：原文写「input text / placeholder 用 360」，与 Input 实际（450）不符；改为输入框内文字与 placeholder 归font-medium。placeholder 不单独设字号，跟随所在控件，所以三个控件的 placeholder 也随之一致。
影响面
selectTriggerClass的 DateRangePicker、宿主侧 Combobox 同样受影响。text-xs）不受影响。Related
packages/ui指针。Validation
scripts/check-ui-contract.mjs通过。vue-tsc（改动仅为 class 字符串与注释）。人工 QA 未进行。Screenshots
改动前（Details 与下拉框的值比 Subject 小一号、细一档）：
改动后（三个字段一致）：