Repository navigation
i18n(zh-CN): edge spaces and keep-as-written names (follow-up to #5) - #6
Merged
Merged
Conversation
Fixes the three things mentioned in filvoch#1 after the import of filvoch#5: - 4 keys: restore the leading/trailing space or newline the source has - 6 keys: keep 'AionCore Meter' as written (was 统计器) - 5 keys: keep 'Aion 2' as written (was 《永恒之塔 2》) Rift/裂缝 and Dungeon/副本 already match the glossary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to the merge of #5, covering exactly the two things you flagged while reconciling: the edge spaces and the keep-as-written names. 15 keys, nothing else.
node scripts/validate-i18n.mjs→ok zh-CN.json.@meta.sourceHashunchanged (1e81ce42…).Edge whitespace — 4 keys
These are not styling choices, they are the separator data the UI concatenates with:
meter.format.parts_separator' · ''·'' · 'win.session.player.overheal_suffix' · cura efetiva … ''· 有效治疗 …'' · 有效治疗 …'guide.video.playlist_prefix'Playlist · ''播放列表 ·''播放列表 · 'app.diag.readme{files}\n{files}{files}\nI had collapsed them because Chinese prose does not want edge spaces — wrong for these four, where the space is the join. Symptom if left alone:
DPS·HPS, a heal suffix glued to the number before it, and a video title glued to 播放列表.Keep-as-written names — 11 keys
AionCore Meter(6 keys): I had translated it to 统计器.cfg.account.retentionhad also lost a character and read 「AionCore 统计」 — a real typo, sorry. All six now keep the product name verbatim:inst.requirements.page.desc,inst.running.close_silent.error,inst.running.close_prompt.desc,inst.running.cancelled.error,inst.uninstall.close_prompt.desc,cfg.account.retention.Aion 2(5 keys): I had used 《永恒之塔 2》, which is the Chinese name the game carried in its first iteration. Reverted to the Latin name — on Global the client says Aion 2, and a player searching for the Chinese title would land on the wrong game. Keys:hotkey.game.remap_note,hotkey.warn.game_alt,hotkey.warn.game_shift,hotkey.warn.game_uses,settings.alertas.convite.clique.desc.What I did not change
Rift/裂缝 and Dungeon/副本 already match the glossary decisions from #1, so they are untouched here.
Kinah→ 基纳 stays translated, per your own decision to adopt the in-game names.If your importer would rather reconcile these itself, close this — but the whitespace ones produce visibly broken strings, so they are worth taking either way.