chore: update vulnerable dependencies#1652
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Dependency ReviewThe following issues were found:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 87 87
Lines 8621 8621
Branches 1492 1492
=======================================
Hits 7423 7423
Misses 1168 1168
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dependabot recently bumped to v10 with open vulnerability
|
@finos/git-proxy-maintainers Ready for review! |
kriswest
left a comment
There was a problem hiding this comment.
LGTM - although are you breaking the CLI by removing yargs and axios? If not please clarify in the desciption, if so, is it possible not to?
|
@kriswest I figured that the dependencies were okay to remove since we aren't publishing I also figured that since the tests were passing, there aren't any issues as the deps are resolving to the Should we keep them around for good dependency hygiene? |
|
I looked at this in more detail: it turns out the CLI was never actually published; up until Since Tracking this in #1653. |
|
Made #1654 to solve the CLI publish issue - will add the missing dependencies back in that PR so we can merge this one ASAP 👍🏼 |
|
Looks like this bumped our scorecard to 9.6 - though a few new vulnerabilities popped up overnight... https://api.securityscorecards.dev/projects/github.com/finos/git-proxy |
Description
Attempts to reduce the number of "vulnerabilities" detected by OSSF Scorecard in our experimental packages and CLI:
nycrequired a major bump, everything else was a minor/patch bump.vitestwas manually bumped to3.2.7, will figure out how to fix properly in the v4 upgrade PR. None of these appear to have broken our tests.Checklist
General
Tests
npm test)npm run lintandnpm run format:check)npm run check-types)