fix(database): prevent FUIArray crash on desynced child events#1377
Open
demolaf wants to merge 8 commits into
Open
fix(database): prevent FUIArray crash on desynced child events#1377demolaf wants to merge 8 commits into
demolaf wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses local model desynchronization issues (GitHub issue #517) in FUIArray by preventing crashes when operations encounter unknown keys. Instead of throwing exceptions, the code now gracefully handles these cases by appending or recovering them as inserts. Unit tests have been added to cover these scenarios. The feedback suggests making the new tests more robust by asserting the exact insertion index of recovered snapshots rather than just verifying the array count.
demolaf
marked this pull request as draft
July 20, 2026 15:00
…ionViewDataSource
…h applied UI updates
demolaf
marked this pull request as ready for review
July 21, 2026 11:03
…llectionView on unbind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517.
FUIArraythrows an uncatchableNSInternalInconsistencyExceptionwhenever a child event references a key missing from its local model — which legitimately happens withqueryLimited(toLast:)under concurrent server-side writes, crashing the app inside the Firebase callback.This guards the four throw sites to reconcile instead of crashing:
removeSnapshot:no-ops when the key is already gone,insertSnapshot:appends on an unknown previous sibling, andchangeSnapshot:/moveSnapshot:recover an unknown key as an insert. Adds a regression test per path.Preview
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-07-21.at.12.02.09.mov