Skip to content

Run shellcheck strict - #175

Merged
firecow merged 1 commit into
mainfrom
strict-shellcheck
Sep 9, 2026
Merged

firecow merged 1 commit into
mainfrom
strict-shellcheck

Conversation

@firecow

@firecow firecow commented Sep 9, 2026

Copy link
Copy Markdown
Owner

The shellcheck job only failed on default-severity findings, so it now runs with every optional check enabled at style severity and the entrypoint script is adjusted to pass.


Summary by cubic

Runs ShellCheck with every optional check at style severity and fixes the script issues it flags.

  • Sets SHELLCHECK_OPTS to --enable=all and severity to style in the QA workflow.
  • Hardens variable expansions in firecow_cloudflared with a default for TUNNEL_LOGLEVEL and quoted expansions.

Written for commit 28d4c98. Summary will update on new commits.

Review in cubic

@firecow firecow self-assigned this Sep 9, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@firecow
firecow merged commit 092e84c into main Sep 9, 2026
5 checks passed
@firecow
firecow deleted the strict-shellcheck branch September 9, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant