Remove unused samples.thread column

[mstange]

Main | Deploy preview

This was added by the merging/diffing code and propagated in various places, but never actually read. There is a possibility that we may want to make use of this field in the future, but it's been many years and it hasn't happened, so let's just remove it for now. We can always add it back once we need it.

I noticed it because it ends up in the "compact" speedometer profiles from CI via profiler-edit --merge-non-overlapping-threads-by-name.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.49%. Comparing base (fe04f38) to head (31bd60e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6151   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files         344      344           
  Lines       36882    36870   -12     
  Branches    10241    10335   +94     
=======================================
- Hits        30793    30783   -10     
+ Misses       5661     5660    -1     
+ Partials      428      427    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[canova]

Ah weird. Yeah, I think we wanted to show which samples came from which thread at some point. But better to remove it.

[canova]

Do we still need to keep these types here? Isn't it better to remove them so we can make sure that they are not used by mistake later?

Also this part of the comment doesn't make sense: "... but tolerated on input so pre-existing profiles still parse". We don't usually care if a table has extra columns.

[mstange]

Oh yes that comment indeed makes no sense.

I was torn on whether to remove the fields from the types. I thought that maybe in the future we might want to have an upgrader that takes that information from old profiles which had it... nevermind, typing it out I realize that this is not going to happen. It's rare for somebody to use the comparison view and even rarer that they would upload the comparison profile. I'll clean this up.

[canova]

Same for this one.