Repository navigation
ci: keep the Firebase JS SDK's build between runs - #193
Closed
sanjevirau wants to merge 2 commits into
Closed
sanjevirau wants to merge 2 commits into
sanjevirau wants to merge 2 commits into
Conversation
Each of the four SDK browser jobs built the SDK from source at its pinned commit, about 4 of its 9-12 minutes. The SDK's build tool (Nx) reuses what it built when the inputs are the same, so its cache is kept between runs, keyed on the SDK commit. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01APfZAFCQzCmvhJqWKMT47g
The cache saved 39 KB and the build still took 193 s: the SDK's nx.json asks for caching in a form its Nx no longer reads. The build target is marked cacheable in the checkout before the build. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01APfZAFCQzCmvhJqWKMT47g
Collaborator
Author
|
Closing: it does not work, measured twice.
The remaining way is for the harness to skip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third round after #191 and #192, for the 0.2.4 milestone.
The four Firebase JS SDK browser jobs are now the longest in CI (9–12 min). About 4 minutes of each is building the SDK from source at its pinned commit, the same build every run. The SDK's build tool (Nx) reuses what it built when the inputs are the same, so this keeps its cache between runs, keyed on the SDK commit. The tests themselves are unchanged.
The first run fills the cache; timings from a second run follow in a comment.
🤖 Generated with Claude Code
https://claude.ai/code/session_01APfZAFCQzCmvhJqWKMT47g