Skip to content

fix: show actual mint fee on Spark send preview - #15

Merged
aramkhx merged 1 commit into
feature/add-firo-networkfrom
aram/dev
Nov 2, 2026
Merged

aramkhx merged 1 commit into
feature/add-firo-networkfrom
aram/dev

Conversation

@aramkhx

@aramkhx aramkhx commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codeant-ai

codeant-ai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #15f00 Reviewed your PR a998d5b Nov 02, 2026 · 15:44 15:48

@codeant-ai

codeant-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

🐒 Monkeys are building your code...

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Nov 2, 2026
@codeant-ai

codeant-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown

CodeAnt-AI Description

Show the actual mint fee before Spark sends

What Changed

  • The Spark transaction review now shows the fee calculated for the mint transaction instead of the previous gas fee.
  • If the fee cannot be calculated, the existing fee remains available.

Impact

✅ Accurate Spark send fee before confirmation

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

onBeforeMount(async () => {
network.value = (await getNetworkByName(selectedNetwork)!) as BitcoinNetwork;
trackSendEvents(SendEventType.SendVerify, { network: network.value.name });
calculatePreviewFee();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: calculatePreviewFee() runs in the background while Confirm stays enabled, so users can approve with the old estimated txData.gasFee; if lookup fails, that estimate remains displayed instead of the mint fee.

Assessment: 🟠 Major · 🔁 Occurrence: Rarely · 🏷️ Possible bug

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** packages/extension/src/ui/action/views/verify-send-to-spark-transaction/index.vue
**Line:** 184:184
**Comment:**
	*Possible Bug: `calculatePreviewFee()` runs in the background while Confirm stays enabled, so users can approve with the old estimated `txData.gasFee`; if lookup fails, that estimate remains displayed instead of the mint fee.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

@codeant-ai

codeant-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟡  Medium Risk

  • The PR needs attention before merging.
  • The fee preview can remain the generic estimate while the mint-fee lookup runs or fails, yet users can still approve the transaction.

Assessed commit: a998d5baf0f4

@aramkhx
aramkhx merged commit cae7463 into feature/add-firo-network Nov 2, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant