Repository navigation
fix: show actual mint fee on Spark send preview - #15
Conversation
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
🐒 Monkeys are building your code... |
CodeAnt-AI DescriptionShow the actual mint fee before Spark sends What Changed
Impact
💡 Usage GuideChecking Your Pull RequestEvery time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. Talking to CodeAnt AIGot a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask: This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ExamplePreserve Org Learnings with CodeAntYou can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input: This helps CodeAnt AI learn and adapt to your team's coding style and standards. ExampleRetrigger reviewAsk CodeAnt AI to review the PR again, by typing: Check Your Repository HealthTo analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health. |
| onBeforeMount(async () => { | ||
| network.value = (await getNetworkByName(selectedNetwork)!) as BitcoinNetwork; | ||
| trackSendEvents(SendEventType.SendVerify, { network: network.value.name }); | ||
| calculatePreviewFee(); |
There was a problem hiding this comment.
Suggestion: calculatePreviewFee() runs in the background while Confirm stays enabled, so users can approve with the old estimated txData.gasFee; if lookup fails, that estimate remains displayed instead of the mint fee.
Assessment: 🟠 Major · 🔁 Occurrence: Rarely · 🏷️ Possible bug
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** packages/extension/src/ui/action/views/verify-send-to-spark-transaction/index.vue
**Line:** 184:184
**Comment:**
*Possible Bug: `calculatePreviewFee()` runs in the background while Confirm stays enabled, so users can approve with the old estimated `txData.gasFee`; if lookup fails, that estimate remains displayed instead of the mint fee.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
No description provided.