Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the launcher as the sole owner of the PasswordVault login credential. Publish a separate short-lived access entry for the read-only DLL in DLL PR #1020, clear it on logout/account replacement, and renew it while the launcher is open.
Renewal uses the existing account gate, skips busy operations and gives each exchange a ten-second timeout. Transient failures retain login. Failed-refresh/profile cleanup finishes before the gate is released, and logout clears access even when the refresh entry is missing. This replaces the shared-writer approach in #6.
The DLL never redeems or updates the refresh credential. Closing the launcher stops renewal; access expires normally and reopening the launcher renews it. Both changes must ship together. Existing issued server sessions retain their current expiry rules.
Validation: synthetic source-linked handoff/renewal/rotation/logout/exclusion/failure tests and full Windows Debug/Release builds passed, with zero build warnings/errors, in PR-only CI with read-only permissions and no publication steps. Packaged-launcher/injected-game vault visibility still needs a Windows smoke test. No merge or deployment.