fix: refresh 2.x scaffolding after the beta and RC releases - #54
Merged
Conversation
Generated extensions could not run static analysis at all. The skeleton still set checkMissingIterableValueType, which PHPStan 2 removed, so 'composer analyse:phpstan' died with 'Invalid configuration' on a freshly created extension — flarum/phpstan ^2.0 installs PHPStan ^2.1. The skeleton also asked for @flarum/jest-config ^1.0.1. Core 2.x uses ^2.0.0, and v1 pulls in flarum-webpack-config ^2.0.1 against the ^3.0.0 the skeleton specifies. The upgrade command already got this right, so an extension upgraded to 2.x was correct while a new one was not. The upgrade command pinned flarum/core, flarum/testing and flarum/phpstan to ^2.0.0-beta, written when 2.0 was in beta and now leaving upgraded extensions asking for a beta of a line that has since reached RC. Those become ^2.0.0, with minimum-stability beta and prefer-stable so the constraint still resolves while 2.0 is prerelease. Its PHP floor also said ^8.2; core 2.x requires ^8.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last release was v3.0.11 in April 2025, before the remaining betas and every RC. Four things have drifted since; the first one stops a generated extension working at all.
Generated extensions can't run static analysis
boilerplate/skeleton/extension/phpstan.neonsetscheckMissingIterableValueType: false, a parameter removed in PHPStan 2.flarum/phpstan ^2.0installs PHPStan^2.1, socomposer analyse:phpstanon a freshly scaffolded extension fails before analysing anything:Verified by running PHPStan 2 against that exact config in a real 2.x extension — and verified fixed the same way (13 files analysed, no configuration error).
Skeleton asks for the wrong jest config
@flarum/jest-config: ^1.0.1, where core 2.x uses^2.0.0. v1 also depends onflarum-webpack-config ^2.0.1, which contradicts the^3.0.0the skeleton specifies in the same file.Worth noting: the upgrade command already sets
^2.0.0, so an extension upgraded to 2.x got this right while a newly created one did not.The upgrade command still writes beta constraints
flarum/core,flarum/testingandflarum/phpstanwere pinned to^2.0.0-beta— correct when written, but it now leaves every upgraded extension asking for a beta of a line that has reached RC.These become
^2.0.0. Since 2.0 is still prerelease, the command now also setsminimum-stability: "beta"andprefer-stable: trueon the extension'scomposer.json, so the constraint resolves while preferring stable releases for everything that has one.PHP floor
The upgrade command rewrote
require.phpto^8.2. Core 2.x requires^8.3.Verification
yarn test— 22 suites, 176 tests, Prettier clean;tsc --noEmitclean. The PHPStan change was checked against a real extension's installed PHPStan 2 rather than by reading.The skeleton's
minimum-stabilitystaysdev— deliberate, and unchanged here.