Repository navigation
CI: opt-in focal/amd64 and bullseye/armhf plugin targets - #1742
Merged
Merged
Conversation
Light builds were only used for noble; bullseye/armhf now uses them too. Same sed as the full plugin Dockerfile. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: FelixHelin <felix.dumitrascu@helindata.com>
plugin-deb.yml gets a 'targets' input. focal/amd64 and bullseye/armhf (cpp, light builds against the published core) are only built when named there, so the default plugin matrix is unchanged. publish-plugin-apt learns the focal codename; it already only touches codenames that got packages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: FelixHelin <felix.dumitrascu@helindata.com>
New 'release-tag' input feeds the same version resolution the release event uses, so a workflow_dispatch can build e.g. 3.1.0~rc.1 for the -rc suites (and light builds pick the core from <codename>-rc). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: FelixHelin <felix.dumitrascu@helindata.com>
There was a problem hiding this comment.
🟡 Changes recommended
The release-tag override can bypass tag/version consistency checks and publish a prerelease to stable suites, while publication verification can miss or incorrectly reject the ARM package.
2 open issues
What changed in this PR
Adds opt-in legacy plugin package targets to complement the core backport in #1741, while preserving the default build matrix.
Changes:
- Adds
targetsfiltering for light C++ builds on focal/amd64 and bullseye/armhf. - Adds
release-tagversion stamping outside release events. - Enables focal apt publishing and switches bullseye light builds to Debian archive repositories.
| File | Description |
|---|---|
.github/workflows/publish-plugin-apt.yml |
Adds focal to supported publishing codenames. |
.github/workflows/plugin-deb.yml |
Adds target selection, legacy build rows, and release-tag version stamping. |
.ci/plugin-deb/cpp/Dockerfile.light |
Configures archived Debian repositories for bullseye builds. |
Review effort: Balanced
- release events always take the version from the release tag; the release-tag input only applies to manual/push runs. - publish-plugin-apt verifies every published codename/arch index (not just amd64) and matches the exact version, so an older package can't satisfy the check. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: FelixHelin <felix.dumitrascu@helindata.com>
helin-ado
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin side of the 3.1.1 backport to focal/amd64 and bullseye/armhf, apt only. The core side is #1741.
plugin-deb.yml: newtargetsinput.focal/amd64andbullseye/armhfare opt-in cpp rows built as light builds against the published fledge core. Default matrix unchanged.publish-plugin-apt.yml: addsfocaltoCODENAMES. It already only regenerates and signs codenames that received packages.Dockerfile.light: bullseye archive.debian.org sed, same as the full cpp Dockerfile (also in CI: opt-in apt-only focal/amd64 and bullseye/armhf targets (3.1.x) #1741, since plugin builds take scripts fromfledge-ref).Callers need to pass
targetsthrough (e.g. the fledge-filter-omfhintbuild-deb.ymlworkflow_dispatch).