test cases util functions - #1661
Open
khoang05 wants to merge 1 commit into
Open
Conversation
elliottslaughter
left a comment
elliottslaughter
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, just some minor formatting and cleanup to do.
Thanks for submitting this!
| #include <vector> | ||
|
|
||
| using namespace ::FlexFlow; | ||
| // checks rhs gets added to the end of lhs |
Collaborator
There was a problem hiding this comment.
I think this is sufficiently clear, so we can remove this comment. Make sure to add a blank line here.
|
|
||
| CHECK(lhs == correct); | ||
| } | ||
| // checks that lhs stays the same when the rhs is empty |
Collaborator
There was a problem hiding this comment.
Also remove this comment and add a blank line.
|
|
||
| CHECK(result == correct); | ||
| } | ||
| SUBCASE("non-empty vector") { |
Collaborator
There was a problem hiding this comment.
I'd add a blank line before this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases for generate_vector, extend_vector, and concat_vectors.
This change is