Repository navigation
Conversation
Assisted-by: OpenCode (Claude Opus 5.5)
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
/importphase toux-designso a team can bring a prototype it already built and start at/evaluate→/handoff, without running/prototype.The Edge/RHEM UX team prototypes in its own repository (a fork of
flightctl-uiwith a fixture API) well before the PRD, design doc, and[UX]story are final. When those settle, the prototype needs only small changes. Today/evaluatehard-requires03-prototype/prototype-notes.md, which only/prototypewrites, so there is no supported way in for an existing prototype.What
/importdoes03-prototype/code/, or a local path'sHEAD), so a moved branch can't be evaluated under an old record.--routesscopes a repo that holds many features).changeset.md.[UX]story's acceptance criteria (verified / mocked / partial / deferred / missing). Deferral needs researcher approval.rfe-snapshot.mdfrom the ingested story so Full evaluation works.It never edits, commits to, or pushes to the prototype repository. Fixes from
/evaluateare made there, then/importruns again at the new commit.Flow
The existing handoff gate is unchanged:
/handoffstill requires an enriched context and a confirmed evaluation bound to the current prototype iteration and context revision.Changes
commands/import.md,skills/import.mdcontroller.md: Import phase, "bring your own prototype" flow, recommendations, phase-entry row; evaluation fix loops route to "fix in repo →/import" for imported prototypes instead of/prototype.evaluate.md: accepts imported prototypes; verifies the recorded commit before evaluating; uses the recorded run command and routes; passes prototype-mode caveats to evaluators; uses the import'srfe-snapshot.md; skips refinement-input normalization (Skill prototype ID: N/A — imported); recordsPrototype commitin the report header.prototype.md: does not refine or overwrite an imported prototype unless the researcher explicitly asks to replace it.handoff.md: uses the imported code at the evaluated commit; treats fixture data as evidence of need, not API proof, and flags fields outside the generated API types as likely backend gaps; records the import in Research Context.README.md,SKILL.md: documented; version0.5.0→0.6.0(new behavior).Open questions
/importalso accept a prototype with no Git history (e.g., a static export)? This draft requires Git so the evaluated artifact is reproducible./importrecords when the prototype's upstream base is older than the discovery baseline but does not resync. Is a warning enough, or should that block evaluation?Validation
skill-reviewer/scripts/pre-review-checks.py --all: ux-design 15/15 passmarkdownlint-cli2 "ux-design/**/*.md": 0 issuesvalidate-structure.sh/validate-versions.shnot run locally (need GNU tooling); relying on CI.Assisted-by: OpenCode (Claude Opus 5.5)