Repository navigation
fix: resolve workflow artifacts from the main worktree - #168
Open
redhat-chai-bot wants to merge 10 commits into
Open
redhat-chai-bot wants to merge 10 commits into
redhat-chai-bot wants to merge 10 commits into
Conversation
Resolve workflow state in the main Git worktree using NUL-delimited worktree metadata. Route phase entry points, configuration, and executable consumers through the shared resolver while preserving source and published-document paths. Refuse legacy per-worktree artifacts without migration or overwrite, document explicit reconciliation and serialized writers, and add cross-worktree and installed-path regressions. Bump affected behavioral package and shared-document versions. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Resolve state targets before rendering or declining provenance, refusing legacy state and symlinked files without mutation. Clarify shared provenance lifetime and preserve active source-branch attribution. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Keep unattended artifact creation and CVE binary verification examples usable when the main checkout path contains spaces. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Use a Bash argument array for the canonical baseline path and exercise the actual start-phase command with and without a saved baseline. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Quote the canonical directory but leave the response filename glob active. Execute the actual cleanup command in a spaced checkout and verify reply files are removed without touching the durable response log. Restore the existing push-remote fallback while keeping metadata reads canonical. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Reject final-file and temporary-file symlinks in CVE, sizing, and reviewer consumers before mutation. Validate transaction targets as a batch and clarify that resolving a directory does not validate appended filenames. Add linked-worktree no-mutation consumer regressions. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Refuse symlinked result files and child decomposition paths before reading or writing canonical state. Preserve ordinary document paths and verify no-mutation refusals from a linked worktree. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Resolve appended state filenames at concrete consumer boundaries, including verification-result removal, without redirecting dependency source files or changing report output contracts. Exercise symlink refusal and no external-data mutation across the CVE consumers. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
Check snapshot parent and read targets, validation log directories and filenames, and temporary worktree paths through the canonical resolver. Preserve the existing explicit snapshot save --force atomic replacement and worktree lifecycle behavior. Assisted-by: Codex <noreply@openai.com> Signed-off-by: Chai Bot <chai-bot@redhat.com>
|
Important Review skippedToo many files! This PR contains 314 files, which is 14 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.artifactsdirectory, using Git's stable NUL-delimited worktree listing rather than the current checkout's root.This keeps local state anchored to the main worktree. It does not change worktree creation, introduce symlinks, or add a separate storage or locking service.
Validation
Skillsaw reports 165 nonfatal warnings and structure checks report 3 nonfatal warnings. Optional interactive IDE smoke testing was not performed.
AI-generated. Review for accuracy.
@wgordon17 requested from Slack
Chai persona:
OSAC