Skip to content

fix: resolve workflow artifacts from the main worktree - #168

Open
redhat-chai-bot wants to merge 10 commits into
flightctl:mainfrom
redhat-chai-bot:fix/shared-worktree-artifacts
Open

redhat-chai-bot wants to merge 10 commits into
flightctl:mainfrom
redhat-chai-bot:fix/shared-worktree-artifacts

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Summary

  • Add a shared resolver for the main worktree's .artifacts directory, using Git's stable NUL-delimited worktree listing rather than the current checkout's root.
  • Route workflow artifact reads, writes, discovery, phase-entry checks, repository configuration, and executable consumers through the canonical root. Preserve source/provenance branch identity, issue-less naming, and published document destinations.
  • Detect legacy artifact state in linked worktrees and stop with explicit reconciliation guidance. Do not automatically migrate, overwrite, or delete existing artifacts. Document no-clobber reconciliation and serialized same-task writes.
  • Add cross-worktree and installed-workflow regression coverage, and update shared recipes, workflow entry points, documentation, and required versions.

This keeps local state anchored to the main worktree. It does not change worktree creation, introduce symlinks, or add a separate storage or locking service.

Validation

  • Python 3.10 and 3.12: 1,706 tests pass on each version (3,412 total).
  • Installer, updater, Codex adapters/runtime client, and pinned Codex 0.163.0 global/project integration pass.
  • Rebase preflight and push-guard tests pass.
  • Markdownlint, Skillsaw, offline Lychee, structure checks, and version validation pass.
  • Full-diff and consumer-path review completed; tracked status and whitespace checks are clean.

Skillsaw reports 165 nonfatal warnings and structure checks report 3 nonfatal warnings. Optional interactive IDE smoke testing was not performed.


AI-generated. Review for accuracy.

@wgordon17 requested from Slack

Chai persona: OSAC

Resolve workflow state in the main Git worktree using NUL-delimited worktree metadata. Route phase entry points, configuration, and executable consumers through the shared resolver while preserving source and published-document paths.

Refuse legacy per-worktree artifacts without migration or overwrite, document explicit reconciliation and serialized writers, and add cross-worktree and installed-path regressions. Bump affected behavioral package and shared-document versions.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Resolve state targets before rendering or declining provenance, refusing legacy state and symlinked files without mutation. Clarify shared provenance lifetime and preserve active source-branch attribution.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Keep unattended artifact creation and CVE binary verification examples usable when the main checkout path contains spaces.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Use a Bash argument array for the canonical baseline path and exercise the actual start-phase command with and without a saved baseline.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Quote the canonical directory but leave the response filename glob active. Execute the actual cleanup command in a spaced checkout and verify reply files are removed without touching the durable response log. Restore the existing push-remote fallback while keeping metadata reads canonical.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Reject final-file and temporary-file symlinks in CVE, sizing, and reviewer consumers before mutation. Validate transaction targets as a batch and clarify that resolving a directory does not validate appended filenames. Add linked-worktree no-mutation consumer regressions.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Refuse symlinked result files and child decomposition paths before reading or writing canonical state. Preserve ordinary document paths and verify no-mutation refusals from a linked worktree.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Resolve appended state filenames at concrete consumer boundaries, including verification-result removal, without redirecting dependency source files or changing report output contracts. Exercise symlink refusal and no external-data mutation across the CVE consumers.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
Check snapshot parent and read targets, validation log directories and filenames, and temporary worktree paths through the canonical resolver. Preserve the existing explicit snapshot save --force atomic replacement and worktree lifecycle behavior.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 314 files, which is 14 over the limit of 300.

To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7653641 and 92dcdec.

Files selected for processing: 314

  • .github/scripts/test-install.sh
  • .github/scripts/validate-structure.sh
  • AGENTS.md
  • README.md
  • _shared/provenance-schema.md
  • _shared/recipes/capture-provenance-event.md
  • _shared/recipes/resolve-artifacts.md
  • _shared/recipes/resolve-docs-publish-remotes.md
  • _shared/scripts/artifacts.py
  • _shared/scripts/pr-comments.py
  • _shared/scripts/provenance.py
  • _shared/scripts/publish.py
  • _shared/scripts/test_artifacts.py
  • _shared/scripts/test_provenance.py
  • bugfix/README.md
  • bugfix/SKILL.md
  • bugfix/commands/assess.md
  • bugfix/commands/diagnose.md
  • bugfix/commands/document.md
  • bugfix/commands/feedback.md
  • bugfix/commands/fix.md
  • bugfix/commands/pr.md
  • bugfix/commands/reproduce.md
  • bugfix/commands/review.md
  • bugfix/commands/start.md
  • bugfix/commands/test.md
  • bugfix/commands/unattended.md
  • bugfix/guidelines.md
  • bugfix/skills/assess.md
  • bugfix/skills/completion.md
  • bugfix/skills/controller.md
  • bugfix/skills/diagnose.md
  • bugfix/skills/dispatch.md
  • bugfix/skills/document.md
  • bugfix/skills/feedback.md
  • bugfix/skills/fix.md
  • bugfix/skills/pr.md
  • bugfix/skills/reproduce.md
  • bugfix/skills/review.md
  • bugfix/skills/start.md
  • bugfix/skills/test.md
  • bugfix/skills/unattended.md
  • code-review/README.md
  • code-review/SKILL.md
  • code-review/commands/clean.md
  • code-review/commands/continue.md
  • code-review/commands/start.md
  • code-review/guidelines.md
  • code-review/skills/clean.md
  • code-review/skills/continue.md
  • code-review/skills/controller.md
  • code-review/skills/start.md
  • cve-fix/README.md
  • cve-fix/SKILL.md
  • cve-fix/commands/backport.md
  • cve-fix/commands/close.md
  • cve-fix/commands/patch.md
  • cve-fix/commands/pr.md
  • cve-fix/commands/report.md
  • cve-fix/commands/scan.md
  • cve-fix/commands/start.md
  • cve-fix/commands/validate.md
  • cve-fix/guidelines.md
  • cve-fix/scripts/_common.py
  • cve-fix/scripts/backport.py
  • cve-fix/scripts/close.py
  • cve-fix/scripts/create_pr.py
  • cve-fix/scripts/finalize_report.py
  • cve-fix/scripts/patch.py
  • cve-fix/scripts/prepare_report.py
  • cve-fix/scripts/report.py
  • cve-fix/scripts/scan.py
  • cve-fix/scripts/verify.py
  • cve-fix/skills/backport.md
  • cve-fix/skills/close.md
  • cve-fix/skills/controller.md
  • cve-fix/skills/downstream-verification.md
  • cve-fix/skills/patch.md
  • cve-fix/skills/pr.md
  • cve-fix/skills/report.md
  • cve-fix/skills/scan.md
  • cve-fix/skills/start.md
  • cve-fix/skills/validate.md
  • design/README.md
  • design/SKILL.md
  • design/commands/decompose.md
  • design/commands/draft.md
  • design/commands/ingest.md
  • design/commands/publish.md
  • design/commands/research.md
  • design/commands/respond.md
  • design/commands/revise.md
  • design/commands/sync.md
  • design/decomposition-review.md
  • design/references/sync-helper-usage.md
  • design/scripts/sync_helper.py
  • design/scripts/test_sync_helper.py
  • design/skills/controller.md
  • design/skills/decompose.md
  • design/skills/draft.md
  • design/skills/ingest.md
  • design/skills/publish.md
  • design/skills/research.md
  • design/skills/respond.md
  • design/skills/revise.md
  • design/skills/sync.md
  • docs-writer/README.md
  • docs-writer/SKILL.md
  • docs-writer/commands/apply.md
  • docs-writer/commands/draft.md
  • docs-writer/commands/gather.md
  • docs-writer/commands/mr.md
  • docs-writer/commands/plan.md
  • docs-writer/commands/validate.md
  • docs-writer/guidelines.md
  • docs-writer/skills/apply-changes.md
  • docs-writer/skills/controller.md
  • docs-writer/skills/create-mr.md
  • docs-writer/skills/draft-content.md
  • docs-writer/skills/gather-context.md
  • docs-writer/skills/plan-structure.md
  • docs-writer/skills/validate.md
  • e2e/README.md
  • e2e/SKILL.md
  • e2e/commands/code.md
  • e2e/commands/ingest.md
  • e2e/commands/plan.md
  • e2e/commands/publish.md
  • e2e/commands/respond.md
  • e2e/commands/revise.md
  • e2e/commands/validate.md
  • e2e/skills/code.md
  • e2e/skills/completion.md
  • e2e/skills/controller.md
  • e2e/skills/dispatch.md
  • e2e/skills/ingest.md
  • e2e/skills/plan.md
  • e2e/skills/publish.md
  • e2e/skills/respond.md
  • e2e/skills/revise.md
  • e2e/skills/validate.md
  • implement/README.md
  • implement/SKILL.md
  • implement/commands/code.md
  • implement/commands/ingest.md
  • implement/commands/plan.md
  • implement/commands/publish.md
  • implement/commands/respond.md
  • implement/commands/revise.md
  • implement/commands/validate.md
  • implement/skills/code.md
  • implement/skills/completion.md
  • implement/skills/controller.md
  • implement/skills/dispatch.md
  • implement/skills/ingest.md
  • implement/skills/plan.md
  • implement/skills/publish.md
  • implement/skills/respond.md
  • implement/skills/revise.md
  • implement/skills/validate.md
  • implement/templates/01-context.md
  • kcs/README.md
  • kcs/SKILL.md
  • kcs/commands/draft.md
  • kcs/commands/gather.md
  • kcs/commands/handoff.md
  • kcs/commands/validate.md
  • kcs/guidelines.md
  • kcs/skills/controller.md
  • kcs/skills/draft.md
  • kcs/skills/gather.md
  • kcs/skills/handoff.md
  • kcs/skills/validate.md
  • prd/GUIDE.md
  • prd/README.md
  • prd/SKILL.md
  • prd/commands/clarify.md
  • prd/commands/draft.md
  • prd/commands/ingest.md
  • prd/commands/publish.md
  • prd/commands/respond.md
  • prd/commands/revise.md
  • prd/skills/clarify.md
  • prd/skills/controller.md
  • prd/skills/draft.md
  • prd/skills/ingest.md
  • prd/skills/publish.md
  • prd/skills/respond.md
  • prd/skills/revise.md
  • rebase-stack/README.md
  • rebase-stack/SKILL.md
  • rebase-stack/commands/continue.md
  • rebase-stack/commands/push.md
  • rebase-stack/commands/start.md
  • rebase-stack/commands/validate.md
  • rebase-stack/scripts/create-missing-prs.sh
  • rebase-stack/scripts/push-guard.sh
  • rebase-stack/scripts/snapshot.sh
  • rebase-stack/scripts/stack-status.sh
  • rebase-stack/scripts/validate-baseline.sh
  • rebase-stack/scripts/validate-branches.sh
  • rebase-stack/skills/continue.md
  • rebase-stack/skills/controller.md
  • rebase-stack/skills/preflight.md
  • rebase-stack/skills/push.md
  • rebase-stack/skills/start.md
  • rebase-stack/skills/validate.md
  • sizing/README.md
  • sizing/SKILL.md
  • sizing/commands/apply.md
  • sizing/commands/assess.md
  • sizing/commands/ingest.md
  • sizing/scripts/_common.py
  • sizing/scripts/apply_plan.py
  • sizing/scripts/finalize_assessment.py
  • sizing/scripts/render_context.py
  • sizing/scripts/test_sizing_scripts.py
  • sizing/skills/apply.md
  • sizing/skills/assess.md
  • sizing/skills/completion.md
  • sizing/skills/controller.md
  • sizing/skills/dispatch.md
  • sizing/skills/ingest.md
  • skill-reviewer/README.md
  • skill-reviewer/SKILL.md
  • skill-reviewer/commands/review.md
  • skill-reviewer/guidelines.md
  • skill-reviewer/prompts/analyze-skill.md
  • skill-reviewer/scripts/pre-review-checks.py
  • skill-reviewer/skills/review.md
  • skills/report-bug/SKILL.md
  • skills/report-bug/references/rendering.md
  • skills/report-bug/scripts/test_render_issue.py
  • triage/README.md
  • triage/SKILL.md
  • triage/commands/analyze.md
  • triage/commands/assess.md
  • triage/commands/report.md
  • triage/commands/run.md
  • triage/commands/scan.md
  • triage/commands/start.md
  • triage/guidelines.md
  • triage/scripts/finalize_analysis.py
  • triage/scripts/prepare_analysis.py
  • triage/scripts/prepare_report.py
  • triage/scripts/render_report.py
  • triage/scripts/scan.py
  • triage/scripts/synthesize_report.py
  • triage/skills/analyze.md
  • triage/skills/assess.md
  • triage/skills/report.md
  • triage/skills/run.md
  • triage/skills/scan.md
  • triage/skills/start.md
  • ui-design/README.md
  • ui-design/SKILL.md
  • ui-design/commands/ingest.md
  • ui-design/commands/plan.md
  • ui-design/commands/publish.md
  • ui-design/commands/respond.md
  • ui-design/commands/review-api.md
  • ui-design/commands/revise.md
  • ui-design/commands/sync.md
  • ui-design/guidelines.md
  • ui-design/skills/completion.md
  • ui-design/skills/controller.md
  • ui-design/skills/dispatch.md
  • ui-design/skills/ingest.md
  • ui-design/skills/plan.md
  • ui-design/skills/publish.md
  • ui-design/skills/respond.md
  • ui-design/skills/review-api.md
  • ui-design/skills/revise.md
  • ui-design/skills/sync.md
  • ui-implement/README.md
  • ui-implement/SKILL.md
  • ui-implement/commands/code.md
  • ui-implement/commands/ingest.md
  • ui-implement/commands/plan.md
  • ui-implement/commands/publish.md
  • ui-implement/commands/respond.md
  • ui-implement/commands/revise.md
  • ui-implement/commands/validate.md
  • ui-implement/skills/code.md
  • ui-implement/skills/completion.md
  • ui-implement/skills/controller.md
  • ui-implement/skills/dispatch.md
  • ui-implement/skills/ingest.md
  • ui-implement/skills/plan.md
  • ui-implement/skills/publish.md
  • ui-implement/skills/respond.md
  • ui-implement/skills/revise.md
  • ui-implement/skills/validate.md
  • ui-implement/templates/01-context.md
  • ux-design/README.md
  • ux-design/SKILL.md
  • ux-design/commands/evaluate.md
  • ux-design/commands/handoff.md
  • ux-design/commands/ingest.md
  • ux-design/commands/prototype.md
  • ux-design/commands/publish.md
  • ux-design/commands/research.md
  • ux-design/commands/respond.md
  • ux-design/commands/revise.md
  • ux-design/guidelines.md
  • ux-design/skills/controller.md
  • ux-design/skills/evaluate.md
  • ux-design/skills/handoff.md
  • ux-design/skills/ingest.md
  • ux-design/skills/prototype.md
  • ux-design/skills/publish.md
  • ux-design/skills/research.md
  • ux-design/skills/respond.md
  • ux-design/skills/revise.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant