Skip to content

Update react-router to v6.30.6 - #888

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:react-router-v6.30.6
Nov 16, 2026
Merged

celdrake merged 1 commit into
flightctl:mainfrom
celdrake:react-router-v6.30.6

Conversation

@celdrake

@celdrake celdrake commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Update router to latest available patched version.

Assisted-by: OpenAI Codex

Scope

This change updates the react-router and react-router-dom version declarations to ^6.30.6. The diff covers 4 files, with 101 lines added and 64 removed.

Affected areas

  • apps/standalone/: react-router-dom range changes from ^6.30.3 to ^6.30.6.
  • apps/ocp-plugin/: react-router-dom-v5-compat changes from the exact pin 6.30.3 to ^6.30.6.
  • libs/ui-components/: Two devDependencies change from exact 6.30.3 to ^6.30.6. The react-router-dom peer dependency changes from ^5.3 || ^6.30.3 to ^5.3 || ^6.30.6.
  • package-lock.json (root): 155 lines changed. This file is part of the diff. Its contents were not inspected, so the resolved versions are not confirmed.

Not affected: libs/types/, libs/i18n/, libs/cypress/, proxy/, packaging/, .github/workflows/. No source files, component code, or E2E tests change.

Cross-cutting implications

  • The libs/ui-components peer dependency range now requires ^6.30.6 for react-router-dom. Any consumer that uses the library with a 6.x router below 6.30.6 no longer satisfies the peer range. Both apps/standalone and apps/ocp-plugin consume this library, so the change affects both apps.
  • The OCP plugin uses the v5-compat package. Its range now accepts 6.30.6 and later, but the change does not alter the ^5.3 peer range for react-router-dom.
  • Only dependency declarations change. Runtime behavior changes depend on the resolved versions in the lock file, which were not checked.

Risk classification

  • Applied label: not available. The labeling criteria for risk:ship, risk:show, and risk:ask were not provided, so the classification cannot be confirmed.
  • Observed factors: The change touches shared library peer dependency ranges and the root lock file. It does not change source code, container builds, CI, the Go proxy, or E2E tests. These factors apply to any classification, but they do not establish a label on their own.
  • Closest alternative: not determinable without the criteria.

Discrepancies with the earlier summary

  • The earlier summary listed three package.json files. The diff also includes package-lock.json.
  • The earlier summary did not mention the peer dependency change in libs/ui-components for consumers below 6.30.6. This summary covers it.

Assisted-by: OpenAI Codex
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

Router dependency and peer dependency version requirements changed in the OCP plugin, standalone app, and UI components library. The updated ranges use version 6.30.6.

Changes

Router Version Ranges

Layer / File(s) Summary
Update router package ranges
libs/ui-components/package.json, apps/ocp-plugin/package.json, apps/standalone/package.json
Updated the router development dependency, peer dependency, and app dependency ranges to use version 6.30.6. The react-router-dom peer range continues to include ^5.3.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested labels: risk:ship, ocp-plugin, standalone, ui-components

Merge Risk: Minimal · up to 69e30

This updates react-router to 6.30.6 in the OCP plugin, the standalone app and the UI components library, and the lockfile resolves to the new version. No merge-blocking risk was found.

Pre-merge checks: Passed 14

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: updating react-router to v6.30.6. The raw summary shows the react-router-dom and react-router dependency ranges moving from 6.30.3 to 6.30.6 across the package.json fi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets Passed The check no-hardcoded-secrets finds no secret in this PR. I read the full diff (refs/coderabbit/pre-merge-check/base to head) and it changes four files: - apps/ocp-plugin/package.json: `react…
No-Weak-Crypto Passed The check is no-weak-crypto. It flags MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom crypto, and non-constant-time comparison of secrets or tokens. The PR changes four files: `apps/ocp-plugin/p…
No-Injection-Vectors Passed The check is inapplicable to this change. The diff range (refs/coderabbit/pre-merge-check/base..head) touches four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components…
Container-Privileges Passed The container-privileges check targets container and Kubernetes manifests. It flags privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root without justification, and allowPrivilegeEscalation…
No-Sensitive-Data-In-Logs Passed The no-sensitive-data-in-logs check does not apply to this change. The PR range changes four files only: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, an…
Resource-Leaks Passed The resource-leaks check applies only to Go files under proxy/. This PR changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-loc…
Unchecked-Errors Passed The unchecked-errors check applies only to Go files under proxy/. The pull request changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and …
Ai-Attribution Passed Summary: The check applies because AI tool use is stated. The PR description and the single commit both declare AI assistance. Evidence: - The PR description ends with `Assisted-by: OpenAI Cod…
Generated-Files-Not-Hand-Edited Passed The check flags direct edits to generated files: libs/types/models/, libs/types/alpha/models/, libs/types/imagebuilder/models/**, and libs/i18n/locales/en/translation.json. The changed-file invent…
I18n-Compliance Passed The i18n-compliance check applies to user-facing strings and t() calls in .tsx files. The reviewed range changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-compone…
Full details: Title check

Explanation

The title names the main change: updating react-router to v6.30.6. The raw summary shows the react-router-dom and react-router dependency ranges moving from 6.30.3 to 6.30.6 across the package.json files, and the PR objectives confirm the react-router v6.30.6 update. The title is specific and matches the changeset.

Full details: No-Hardcoded-Secrets

Explanation

The check no-hardcoded-secrets finds no secret in this PR. I read the full diff (refs/coderabbit/pre-merge-check/base to head) and it changes four files: - apps/ocp-plugin/package.json: react-router-dom-v5-compat moves from 6.30.3 to ^6.30.6. - apps/standalone/package.json: react-router-dom moves from ^6.30.3 to ^6.30.6. - libs/ui-components/package.json: the devDependency and peerDependency ranges move to ^6.30.6. - package-lock.json: version, resolved URL and integrity values for the react-router packages are updated. No API key, token, password, private key or credential appears. No URL contains embedded credentials. No variable named api_key, secret, token or password gets a string literal. The only long base64 strings are the sha512-... integrity hashes in package-lock.json. These are public npm package checksums. They are not secrets. The lock file is also not application config. I therefore did not treat them as a violation of the check. Author identity does not apply to this check.

Full details: No-Weak-Crypto

Explanation

The check is no-weak-crypto. It flags MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom crypto, and non-constant-time comparison of secrets or tokens. The PR changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. The changes only bump react-router, react-router-dom, react-router-dom-v5-compat, and their transitive @remix-run/router to 6.30.6 / 1.23.4. No source code changed. A keyword scan of the added lines found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, cipher, or comparison code. The only hash values in the lockfile are sha512 SRI integrity fields for npm package tarballs. SHA-512 is not a weak algorithm under this check, and these fields are package-integrity metadata, not new cryptographic code. No failure condition in the check is introduced.

Full details: No-Injection-Vectors

Explanation

The check is inapplicable to this change. The diff range (refs/coderabbit/pre-merge-check/base..head) touches four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. The package.json edits only change react-router and react-router-dom version specifiers (6.30.3 to 6.30.6, with some ranges converted to ^). The non-lockfile diff contains no source-code changes. It has no eval or exec calls, no dangerouslySetInnerHTML, no os.system or exec.Command, and no yaml.load. The package-lock.json diff is a resolved-version update and contains no code that the check covers. No failure condition in the custom check is introduced.

Full details: Container-Privileges

Explanation

The container-privileges check targets container and Kubernetes manifests. It flags privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root without justification, and allowPrivilegeEscalation: true. The PR changes only dependency declarations. The changed-file inventory from refs/coderabbit/pre-merge-check/base to head is: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. No Dockerfile, Containerfile, Helm chart, Kubernetes YAML, or deployment manifest changed. The check does not apply to this PR, and none of its failure conditions is present. Verdict: PASS.

Full details: No-Sensitive-Data-In-Logs

Explanation

The no-sensitive-data-in-logs check does not apply to this change. The PR range changes four files only: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. These are dependency version bumps for react-router and react-router-dom to ^6.30.6, plus the matching lock entries. The added lines contain no source code and no logging calls. A search of the added lines for console, logger, log, debug, printf, token, password, secret, and apiKey found no matches. No new logging path or sensitive-data exposure is introduced.

Full details: Resource-Leaks

Explanation

The resource-leaks check applies only to Go files under proxy/. This PR changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. The diff range contains no .go files and nothing under proxy/. The check does not apply to this PR, so it passes. The changes are react-router dependency range updates to v6.30.6 (PR #888 by celdrake). They do not add or modify any file handles, HTTP response bodies, network connections, or goroutines.

Full details: Unchecked-Errors

Explanation

The unchecked-errors check applies only to Go files under proxy/. The pull request changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. The diff range contains no Go files and no files under proxy/. The check does not apply, so it passes. The PR only updates react-router dependency ranges to v6.30.6.

Full details: Ai-Attribution

Explanation

Summary: The check applies because AI tool use is stated. The PR description and the single commit both declare AI assistance. Evidence: - The PR description ends with Assisted-by: OpenAI Codex. - The commit 69e305bf2ffae74b12d6c2f0389462229a9ad5a0 ("Update react-router to v6.30.6") has the trailer Assisted-by: OpenAI Codex in its message body. I read the full message with git log over the reviewed range. - Assisted-by is an accepted attribution trailer under this check. - No Co-Authored-By trailer appears in the commit message or the PR description. The check's flag condition for AI tools does not apply. Result: The AI attribution uses an accepted trailer. No failure condition is met.

Full details: Generated-Files-Not-Hand-Edited

Explanation

The check flags direct edits to generated files: libs/types/models/, libs/types/alpha/models/, libs/types/imagebuilder/models/**, and libs/i18n/locales/en/translation.json. The changed-file inventory for the reviewed range (refs/coderabbit/pre-merge-check/base to head) lists four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. None of these matches a protected generated path. The PR only bumps react-router and react-router-dom dependency ranges and the lockfile. No generated model or translation file was touched, so the check is satisfied.

Full details: I18n-Compliance

Explanation

The i18n-compliance check applies to user-facing strings and t() calls in .tsx files. The reviewed range changes four files: apps/ocp-plugin/package.json, apps/standalone/package.json, libs/ui-components/package.json, and package-lock.json. A diff filtered to '*.tsx' returned no files, so this PR adds or modifies no .tsx source. The changes are dependency version ranges (react-router and react-router-dom moving to v6.30.6) and lockfile updates. None of these introduces a user-facing string or a t() call, so no explicit failure condition of the check is met. The check is inapplicable to this change set and passes.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 68dcdf1 and 69e305b.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 3

  • apps/ocp-plugin/package.json
  • apps/standalone/package.json
  • libs/ui-components/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@celdrake
celdrake requested a review from asmasarw November 16, 2026 09:28
@coderabbitai coderabbitai Bot added ocp-plugin risk:ship Ship: trivial, low-risk — auto-merge candidate standalone ui-components labels Nov 16, 2026
@celdrake
celdrake added this pull request to the merge queue Nov 16, 2026
Merged via the queue into flightctl:main with commit a7812fb Nov 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants