Follow redirects based on the request and strip credentials on cross-…#4226
Open
WelschChristopher wants to merge 1 commit into
Open
Conversation
WelschChristopher
force-pushed
the
follow-redirect-strip-sensitive-headers
branch
from
July 23, 2026 09:39
6745b6d to
e931eda
Compare
…host redirects The Spring WebClient based FlowableHttpClient never followed redirects. It now follows them unless the request disables redirects (HttpRequest#isNoRedirects). The decision is made per request: a Reactor context value is written on the exchange and read by a Reactor Netty followRedirect predicate, so a single client/connection pool is used. The Apache HttpClient 5 based client refused to follow a redirect to a different host when the request carried credentials or cookies. It now strips those sensitive headers (Authorization, Cookie, Proxy-Authorization) on cross-host redirects and follows the redirect, so content behind a redirect can be retrieved without leaking credentials to the redirect target. Reactor Netty already drops sensitive headers on cross-domain redirects.
WelschChristopher
force-pushed
the
follow-redirect-strip-sensitive-headers
branch
from
July 24, 2026 08:38
e931eda to
08432c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…host redirects
The Spring WebClient based FlowableHttpClient never followed redirects. It now follows them unless the request disables redirects (HttpRequest#isNoRedirects), consistent with the Apache HttpClient based clients. This is implemented with two WebClients (one following redirects, one not) selected per request.
The Apache HttpClient 5 based client refused to follow a redirect to a different host when the request carried credentials or cookies. It now strips those sensitive headers (Authorization, Cookie, Proxy-Authorization) on cross-host redirects and follows the redirect, so content behind a redirect can be retrieved without leaking credentials to the redirect target.
Reactor Netty already drops sensitive headers on cross-domain redirects.
Check List: