refactor: deduplicate shared downloads across test suites review - #395
Merged
Merged
Conversation
Contributor
Author
|
AC verification:
|
rsanchez87
force-pushed
the
download-dedup-review
branch
from
September 29, 2026 12:29
4f68683 to
3f373f6
Compare
mdimopoulos
requested changes
Sep 29, 2026
rsanchez87
force-pushed
the
download-dedup-review
branch
2 times, most recently
from
September 29, 2026 14:42
09754a0 to
94c6f9a
Compare
mdimopoulos
approved these changes
Sep 29, 2026
dabrain34
reviewed
Sep 29, 2026
- Simplify download manager and zip extraction - Use download_test_suite() in TestSuite.download() (it was unused) - Type test suites as TestSuite instead of Any - Report which source failed when a download errors - Fix the file's copyright year (2026, not 2020)
rsanchez87
force-pushed
the
download-dedup-review
branch
from
September 30, 2026 08:35
94c6f9a to
11748d8
Compare
rsanchez87
changed the title
Contributor
|
Sorry about this misunderstanding with my thumb up. I was reviewing again and found some pitfalls such as the license in download_manager.py could be shared but no worries. I can create another PR to fix the issues. |
Contributor
Author
Ok, sorry about the misunderstanding, too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the review of #390
cc @dabrain34