Repository navigation
file: recover legacy checksums and validate shadow header fallback - #118
Merged
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stored chunks can fail checksum validation when an older writer leaves an unfinished CRC or uses the legacy 64-bit big-endian checksum layout. Recover those layouts after validating the content, and add a shadow content-length/CRC tuple in the existing header padding as a fallback when the primary header fails validation. Writable recovery repairs the primary header; read-only recovery leaves the file unchanged.
A valid primary tuple always takes precedence over the shadow. Otherwise, an older writer can append and sync 18 bytes while leaving a valid 9-byte shadow, and reopening the chunk would silently restore the 9-byte length. The same ambiguity can undo a truncation. Without a generation marker, two valid tuples cannot establish which is newer, so recovery preserves the primary even if the shadow describes additional bytes. This is a recovery fallback, not an atomic commit protocol.
The changes also persist zero-length write_at truncations correctly and validate shadow lengths by subtraction to prevent 32-bit arithmetic overflow. A crafted UINT32_MAX shadow length previously passed the size check under Emscripten and could be accepted with a checksum over the wrapped length.
Coverage includes legacy format fixtures, read-only recovery, append/truncation with stale shadows, corrupt payloads and headers, maximum shadow lengths, and Fluent Bit storage lifecycle behavior.
Validation:
Windows and macOS execution is left to the repository's PR CI.