Repository navigation
parser_json: speed up parsing when no value conversion is configured - #5579
Merged
Merged
Conversation
Since fluent#4474, parse calls convert_values for every record through parse_one_record. convert_values returns a new [time, record] array even when types, null_value_pattern and null_empty_string are not set. Check @execute_convert_values in parse again, as before fluent#4474, and remove parse_one_record. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
The assertions were only in the block, so the test passed even when parse yielded nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Since #4474,
JSONParser#parsecallsconvert_valuesfor every record throughparse_one_record.convert_valuesreturns a new[time, record]array even whentypes,null_value_patternandnull_empty_stringare not set. This PR checks@execute_convert_valuesinparseagain, as before #4474, and removesparse_one_record. I found no plugin on RubyGems that calls or overridesparse_one_record, or that overridesconvert_valuesin aJSONParsersubclass.rake benchmark:run:in_tail(1 GB of JSON lines), median in shuffled order:@type filewith@type nullintasks/benchmark/conf/in_tail.conf.Docs Changes:
None.
Release Note:
parser_json: Improve parsing performance when no value conversion is configured.
🤖 Generated with Claude Code