Skip to content

Remove leftover NUI code paths - #204

Merged
JSUYA merged 1 commit into
flutter-tizen:mainfrom
JSUYA:remove-nui-support
Oct 6, 2026
Merged

JSUYA merged 1 commit into
flutter-tizen:mainfrom
JSUYA:remove-nui-support

Conversation

@JSUYA

@JSUYA JSUYA commented Oct 1, 2026

Copy link
Copy Markdown
Member

#184 removed the NUI/Dali embedding support, but a few code paths that only served the NUI image view were left behind. Every remaining view is a TizenWindow, so these paths are unreachable. Remove them.

  • tizen_input_method_context_tcore.*: Remove HandleNuiKeyEvent(). It was carried into the tizen-core input method context (Support tizen-core window #195) after Remove FlutterView (NUI/Dali embedding) support #184, and was always compiled out because NUI_SUPPORT is no longer defined.
  • tizen_renderer_egl.cc: Remove the tbm dummy display fallback, which was used when the view had no native display (the NUI image view). Fail early if no display is given instead of creating a dummy display that is never released.
  • flutter_tizen_view.cc: Remove the non-window branch from SendInitialGeometry().

No behavior change for window-based views.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@JSUYA

JSUYA commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

Um... I still have remaining Codex usage and plenty of credits. Codex is acting up, though; it is currently known that the codex review bot for pull requests created from forked git repo isn't working properly.

@JSUYA

JSUYA commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

The current CI build error requires #203.

HandleNuiKeyEvent() was carried into the tizen-core input method
context (flutter-tizen#195) after NUI/DALi embedding support had already been
removed (flutter-tizen#184). NUI_SUPPORT is never defined and the function has no
callers, so the block was always compiled out.
@JSUYA
JSUYA force-pushed the remove-nui-support branch from 7549bd6 to e8a4087 Compare October 6, 2026 04:27
@JSUYA
JSUYA merged commit b0e4757 into flutter-tizen:main Oct 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants