Skip to content

Sync client_wrapper with upstream Flutter - #206

Merged
seungsoo47 merged 1 commit into
flutter-tizen:mainfrom
seungsoo47:bot/upstream-embedder-client-wrapper-sync
Oct 7, 2026
Merged

seungsoo47 merged 1 commit into
flutter-tizen:mainfrom
seungsoo47:bot/upstream-embedder-client-wrapper-sync

Conversation

@seungsoo47

Copy link
Copy Markdown
Contributor

Apply the upstream client_wrapper changes that the source syncs missed. They are already in the pinned Flutter commit (6655482ec0):

Apply the upstream client_wrapper changes that the source syncs missed.
They are already in the pinned Flutter commit (6655482ec0):

- Take StreamHandlerError strings by const reference.
  flutter-team-archive/engine#46058 (42bac1a9a9)
- Move std::function arguments instead of copying them, and take the
  MethodChannel handler by const reference.
  flutter/flutter#173429 (f45a8f8b71)
- Point the channel_buffers.dart link to the flutter/flutter repo.
  flutter/flutter#182600 (2d7e80963b)
@JSUYA

JSUYA commented Oct 6, 2026

Copy link
Copy Markdown
Member

#36
In the past, modifications of this type were rolled back due to c++ breaks.
For this reason, there are specific parts we intentionally preserve in the diff during version updates.
You need to verify that no issues arise.

@seungsoo47

Copy link
Copy Markdown
Contributor Author

#36 In the past, modifications of this type were rolled back due to c++ breaks. For this reason, there are specific parts we intentionally preserve in the diff during version updates. You need to verify that no issues arise.

Thank you for the review. I checked the diffs we keep on purpose: the .get() patch in event_channel.h (#36) and the removal of engine_method_result.cc (#44). This PR doesn't change either of them. The #36 fix made the StreamHandlerError members values; this PR only takes the constructor parameters by const&, and the members are still values.

Verified:

  • Embedder CI passes, and the arm and arm64 builds succeed.
  • Plugins that use the changed APIs build with the Tizen SDK LLVM-10 / rootstrap 6.0 toolchain.
  • On an RPi4 (Tizen 10.1), with the embedder built from this branch, the integration tests give the same results as before.
    messageport, geolocator and video_player pass.

@seungsoo47
seungsoo47 merged commit 4c0cfbf into flutter-tizen:main Oct 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants