Repository navigation
Sync client_wrapper with upstream Flutter - #206
seungsoo47 merged 1 commit into
Conversation
Apply the upstream client_wrapper changes that the source syncs missed. They are already in the pinned Flutter commit (6655482ec0): - Take StreamHandlerError strings by const reference. flutter-team-archive/engine#46058 (42bac1a9a9) - Move std::function arguments instead of copying them, and take the MethodChannel handler by const reference. flutter/flutter#173429 (f45a8f8b71) - Point the channel_buffers.dart link to the flutter/flutter repo. flutter/flutter#182600 (2d7e80963b)
|
#36 |
Thank you for the review. I checked the diffs we keep on purpose: the .get() patch in event_channel.h (#36) and the removal of engine_method_result.cc (#44). This PR doesn't change either of them. The #36 fix made the StreamHandlerError members values; this PR only takes the constructor parameters by const&, and the members are still values. Verified:
|
Apply the upstream client_wrapper changes that the source syncs missed. They are already in the pinned Flutter commit (6655482ec0):
client_wrapperheaders. flutter-team-archive/engine#46058 (42bac1a9a9)flutter/enginewithflutter/flutterflutter/flutter#182600 (2d7e80963b)