Repository navigation
[audioplayers] Fix seek and playback completion handling - #1168
Merged
seungsoo47 merged 5 commits intoOct 2, 2026
Merged
seungsoo47 merged 5 commits into
seungsoo47 merged 5 commits into
Conversation
seungsoo47
commented
Sep 22, 2026
seungsoo47
commented
Contributor
- Serialize seeks and defer playback controls until seeking completes.
- Avoid missing network seek completion callbacks after stop by rewinding while paused.
- Reset the playback position before reporting completion in stop mode.
Member
|
@codex review |
JSUYA
reviewed
Sep 22, 2026
seungsoo47
force-pushed
the
audioplayers/fix-seek-completion-handling
branch
from
September 28, 2026 05:50
42f1ca1 to
ca10229
Compare
seungsoo47
force-pushed
the
audioplayers/fix-seek-completion-handling
branch
from
September 30, 2026 06:02
ca10229 to
6d7c6d1
Compare
JSUYA
reviewed
Sep 30, 2026
- Do not discard a pending completion on pause. - Report a pending completion before play, stop and source reset. - Report completion even if re-preparing fails after playback ends. - Run the deferred play when a chained seek fails.
JSUYA
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.