Send best-effort Slack notifications for new customer signups - #104
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New customer registrations now schedule a best-effort Slack workflow notification after the registration response. The server-only
SLACK_SIGNUP_WEBHOOK_URLconfigures the destination; the payload is{ "app": "ftown", "customer": "<email>", "email": "<email>" }.INSERT ... RETURNING idensures only newly created accounts trigger notifications, including concurrent duplicate registration attempts. Missing configuration skips delivery. Network errors, non-2xx responses, and a three-second timeout are ignored without retries, preserving account creation behavior and the existing non-enumerating response.Validation: all 279 UI tests pass, and the production build passes (including lint/type checks, with dummy build-only auth secrets). Added eight registration tests covering deferred delivery, the exact payload, duplicate/concurrent accounts, missing configuration, insertion failure, and network/HTTP/timeout failures. All webhook requests in tests are mocked; no live Slack messages sent.
Deployment configuration: set
SLACK_SIGNUP_WEBHOOK_URLin the UI server environment. The actual webhook URL is not committed.