Repository navigation
Update ModuleDescriptor identifiers in the Gradle workflow - #177
Merged
david-igbinedion merged 1 commit intoOct 7, 2026
Merged
david-igbinedion merged 1 commit into
david-igbinedion merged 1 commit into
Conversation
Contributor
|
@david-igbinedion and @alb3rtino -- I do not see any testing at mod-agreements. Today i created a release at .github as v1.17.5 so that means that this is now included in the default Please monitor the relevant Action runs at a Gradle-based repository to ensure that this Workflow now has the desired outcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Gradle workflow publishes the ModuleDescriptor as built. Every snapshot build therefore has the same id (e.g.
mod-agreements-7.4.0-SNAPSHOT, without the build number of the Docker tag). The registry accepts the first publish and rejects every later one with status 400.In mod-agreements the first master run after the migration (#15) published, and the two runs since failed in "Publish ModuleDescriptor": #29 and #32. The other four Gradle modules have had one master run each and will fail on their next one.
Approach
Add a step to
gradle-build.ymlthat sets theidfrom the artifact version, with the samejqexpression asmaven-module-descriptor-get.yml. This aligns the Gradle workflow with the Maven workflow, whose style #165 set out to follow.On top of that, the expression sets
launchDescriptor.dockerImageandlaunchDescriptor.dockerPull, as it does for Maven. Until now the Gradle descriptor names the image without the Docker Hub organization and hasdockerPullfalse.The step is tested locally against the mod-agreements descriptor and a local Okapi.
Additional observation
The Maven workflow runs an Okapi dependency check for release builds. The Gradle workflow has none.