Skip to content

Update ModuleDescriptor identifiers in the Gradle workflow - #177

Merged
david-igbinedion merged 1 commit into
folio-org:masterfrom
alb3rtino:gradle-module-descriptor-identifiers
Oct 7, 2026
Merged

david-igbinedion merged 1 commit into
folio-org:masterfrom
alb3rtino:gradle-module-descriptor-identifiers

Conversation

@alb3rtino

Copy link
Copy Markdown
Contributor

Purpose

The Gradle workflow publishes the ModuleDescriptor as built. Every snapshot build therefore has the same id (e.g. mod-agreements-7.4.0-SNAPSHOT, without the build number of the Docker tag). The registry accepts the first publish and rejects every later one with status 400.

In mod-agreements the first master run after the migration (#15) published, and the two runs since failed in "Publish ModuleDescriptor": #29 and #32. The other four Gradle modules have had one master run each and will fail on their next one.

Approach

Add a step to gradle-build.yml that sets the id from the artifact version, with the same jq expression as maven-module-descriptor-get.yml. This aligns the Gradle workflow with the Maven workflow, whose style #165 set out to follow.

On top of that, the expression sets launchDescriptor.dockerImage and launchDescriptor.dockerPull, as it does for Maven. Until now the Gradle descriptor names the image without the Docker Hub organization and has dockerPull false.

The step is tested locally against the mod-agreements descriptor and a local Okapi.

Additional observation

The Maven workflow runs an Okapi dependency check for release builds. The Gradle workflow has none.

@david-igbinedion
david-igbinedion merged commit ae5c9d3 into folio-org:master Oct 7, 2026
2 checks passed
@dcrossleyau

Copy link
Copy Markdown
Contributor

@david-igbinedion and @alb3rtino -- I do not see any testing at mod-agreements. Today i created a release at .github as v1.17.5 so that means that this is now included in the default @v1 being used by the Workflow at mod-agreements.

Please monitor the relevant Action runs at a Gradle-based repository to ensure that this Workflow now has the desired outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants